Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rejectProject function, add userId to projects, add desktop and cli platforms, misc fixes #20

Merged
merged 9 commits into from
Jun 5, 2023
Merged

feat: rejectProject function, add userId to projects, add desktop and cli platforms, misc fixes #20

merged 9 commits into from
Jun 5, 2023

Conversation

loks0n
Copy link
Member

@loks0n loks0n commented Jun 2, 2023 •
edited
Loading

What does this PR do?

  • adds 'desktop', 'cli', and 'other' platforms
  • fix bug in spacing between project tags
  • add userId to projects attributes
  • add some details to submitProject docs
  • add rejectProject function: sends an email to the project author when a rejectionReason is provided

Test Plan

Manuel

Have you read the Contributing Guidelines on issues?

Yes

@vercel
Copy link

vercel bot commented Jun 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
built-with-appwrite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2023 11:41am

Meldiron
Meldiron reviewed Jun 5, 2023
View reviewed changes
src/Config.ts Show resolved Hide resolved
Meldiron
Meldiron reviewed Jun 5, 2023
View reviewed changes
Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left review

Meldiron
Meldiron reviewed Jun 5, 2023
View reviewed changes
functions/rejectProject/README.md

List of environment variables used by this cloud function:

- **APPWRITE_FUNCTION_ENDPOINT** - Endpoint of Appwrite project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let'ß document APPROVED_EMAILS since we added it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@loks0n loks0n merged commit bc4f2ef into main Jun 5, 2023
@stnguyen90 stnguyen90 mentioned this pull request Jul 22, 2023
Merged
This was referenced Jul 25, 2023
Closed
Closed
Closed
Closed
This was referenced Jul 25, 2023
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meldiron Meldiron Meldiron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loks0n @Meldiron