Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flutter Real-time Voting App #483

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Conversation

0niel
Copy link
Contributor

@0niel 0niel commented Apr 14, 2023

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

Yes

Copy link
Member

@adityaoberai adityaoberai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @0niel!

I noticed that the project has a secret value explicitly mentioned in the repo.

Would you like to exclude this file from the repo and reset the values maybe? You can instead have an example file or a markdown with instructions on how to create this constants.dart file instead.

@adityaoberai
Copy link
Member

Hi @0niel
Were you able to check the review I sent earlier and make the recommended changes?

@0niel
Copy link
Contributor Author

0niel commented Jun 16, 2023

Hi @0niel Were you able to check the review I sent earlier and make the recommended changes?

Hi! I deleted the secrets, thank you!

I don't see much point in deleting the collection id in `constants.dart'. The application implies manually changing them in the source when required

@adityaoberai
Copy link
Member

Hi @0niel Were you able to check the review I sent earlier and make the recommended changes?

Hi! I deleted the secrets, thank you!

I don't see much point in deleting the collection id in `constants.dart'. The application implies manually changing them in the source when required

Fair enough 👍
This should be good to merge then!

@adityaoberai adityaoberai merged commit 476cebb into appwrite:master Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants