Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracting function event validator to its own class. #6219

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Extracting function event validator to its own class. #6219

merged 2 commits into from
Sep 13, 2023

Conversation

byawitz
Copy link
Member

@byawitz byawitz commented Sep 12, 2023

What does this PR do?

Closes #6218

Test Plan

  1. Added FunctionEventValidatorTest.php which is the same as EventValidatorTest.php except that any event that starts with functions. will return false.
  2. Tested it on a temporary local Appwrite instance, and I was able to add the functions.* events to a webhook but not to a function.

Related PRs and Issues

#6218

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please also uncomment the functions test in the event validator unit test?

@byawitz
Copy link
Member Author

byawitz commented Sep 12, 2023

Done

@byawitz byawitz requested a review from stnguyen90 September 12, 2023 04:08
@abnegate abnegate merged commit 6be6a96 into appwrite:master Sep 13, 2023
4 checks passed
@christyjacob4 christyjacob4 mentioned this pull request Sep 14, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Can't set function event to trigger Webhook
3 participants