Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migrations worker #6116

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Fix migrations worker #6116

merged 3 commits into from
Sep 6, 2023

Conversation

abnegate
Copy link
Contributor

@abnegate abnegate commented Sep 1, 2023

What does this PR do?

(Provide a description of what this PR does and why it's needed.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@abnegate abnegate changed the base branch from master to 1.4.x September 1, 2023 23:20
@stnguyen90 stnguyen90 added this to the 1.4.2 milestone Sep 2, 2023
@stnguyen90 stnguyen90 self-requested a review September 2, 2023 00:05
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. just 1 question

app/views/install/compose.phtml Show resolved Hide resolved
@eldadfux eldadfux added the waiting for release Fixed or implemented and waiting for a new version to be released label Sep 2, 2023
@stnguyen90 stnguyen90 modified the milestones: 1.4.2, 1.4.3 Sep 2, 2023
@Meldiron
Copy link
Contributor

Meldiron commented Sep 5, 2023

File dif comparing docker-compose.yml to compose.phtml: https://www.diffchecker.com/sASIAiLt/

app/views/install/compose.phtml Outdated Show resolved Hide resolved
@christyjacob4
Copy link
Member

@Meldiron can you look into the indentation of the file ?

@christyjacob4 christyjacob4 merged commit 8dfd41c into 1.4.x Sep 6, 2023
@abnegate abnegate deleted the fix-migrations-worker branch October 25, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for release Fixed or implemented and waiting for a new version to be released
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants