Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat messages event config #5986

Merged
merged 18 commits into from
Sep 14, 2023
Merged

Feat messages event config #5986

merged 18 commits into from
Sep 14, 2023

Conversation

fanatic75
Copy link
Contributor

@fanatic75 fanatic75 commented Aug 14, 2023

What does this PR do?

This PR adds event config for messages and adds target attribute in User's response Model

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

This PR is dependent on #5951

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@fanatic75 fanatic75 added the product / messaging Fixes and upgrades for the Appwrite Messaging. label Aug 14, 2023
@fanatic75 fanatic75 requested review from wess and abnegate August 14, 2023 15:44
@abnegate abnegate changed the base branch from 1.4.x to 1.5.x August 17, 2023 21:58
Comment on lines 261 to 274
'providers' => [
'$model' => Response::MODEL_PROVIDER,
'$resource' => true,
'$description' => 'This event triggers on any provider event.',
'create' => [
'$description' => 'This event triggers when a provider is created.',
],
'update' => [
'$description' => 'This event triggers when a provider is updated.',
],
'delete' => [
'$description' => 'This event triggers when a provider is deleted.'
],
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move providers to the top level instead of nesting (contrary to the RFC), they're generic enough that we could potentially use them for other provider types like auth in future

@abnegate abnegate merged commit afd421e into 1.5.x Sep 14, 2023
@abnegate abnegate deleted the feat-messages-event-config branch October 25, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product / messaging Fixes and upgrades for the Appwrite Messaging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants