-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat messages event config #5986
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanatic75
added
the
product / messaging
Fixes and upgrades for the Appwrite Messaging.
label
Aug 14, 2023
…om/appwrite/appwrite into feat-messages-event-config
…om/appwrite/appwrite into feat-messages-event-config
…om/appwrite/appwrite into feat-messages-event-config
…om/appwrite/appwrite into feat-messages-event-config
…om/appwrite/appwrite into feat-messages-event-config
…om/appwrite/appwrite into feat-messages-event-config
…om/appwrite/appwrite into feat-messages-event-config
…om/appwrite/appwrite into feat-messages-event-config
…t-messages-event-config
abnegate
reviewed
Sep 14, 2023
app/config/events.php
Outdated
Comment on lines
261
to
274
'providers' => [ | ||
'$model' => Response::MODEL_PROVIDER, | ||
'$resource' => true, | ||
'$description' => 'This event triggers on any provider event.', | ||
'create' => [ | ||
'$description' => 'This event triggers when a provider is created.', | ||
], | ||
'update' => [ | ||
'$description' => 'This event triggers when a provider is updated.', | ||
], | ||
'delete' => [ | ||
'$description' => 'This event triggers when a provider is deleted.' | ||
], | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move providers to the top level instead of nesting (contrary to the RFC), they're generic enough that we could potentially use them for other provider types like auth in future
abnegate
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds event config for messages and adds target attribute in User's response Model
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
This PR is dependent on #5951
Checklist