Fix 5404 update doc without relation permission #5815
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnguyen90
reviewed
Jul 14, 2023
added 3 commits
July 18, 2023 16:46
…x-5404-update-doc-without-relation-permission
abnegate
reviewed
Jul 26, 2023
| @@ -3280,7 +3276,6 @@ function updateAttribute( | |||
| } | |||
|
|
|||
| $data = \array_merge($document->getArrayCopy(), $data); // Merge existing data with new data | |||
| $data['$collection'] = $collection->getId(); // Make sure user doesn't switch collectionID | |||
There was a problem hiding this comment.
Do we need to remove this?
| $checkPermissions($collection, $newDocument, $document, Database::PERMISSION_UPDATE); | ||
| ; |
| $checkPermissions($collection, $newDocument, $document, Database::PERMISSION_UPDATE); | ||
| ; | ||
| } | ||
|
|
There was a problem hiding this comment.
Let's keep just one line between code blocks
|
|
||
| public function testUpdateWithoutRelationPermission(): void | ||
| { | ||
|
|
There was a problem hiding this comment.
Let's have no blank lines at the start of function
| ]); | ||
|
|
||
| $databaseId = $database['body']['$id']; | ||
|
|
There was a problem hiding this comment.
Let's keep just one line between code blocks
| ]); | ||
|
|
||
| \sleep(3); | ||
|
|
There was a problem hiding this comment.
Let's keep just one blank line between code blocks
| 'permissions' => [], | ||
| ]); | ||
|
|
||
| \sleep(3); |
| ]); | ||
| $this->assertEquals(201, $parentDocument['headers']['status-code']); | ||
|
|
||
| \sleep(3); |
Comment on lines
+3361
to
+3363
| $relation->removeAttribute('$collectionId'); | ||
| $relation->removeAttribute('$databaseId'); | ||
| $relation->setAttribute('$collection', $relatedCollection->getId()); |
There was a problem hiding this comment.
I think we can do this outside the foreach loop
Comment on lines
+3393
to
+3395
| $newDocument->removeAttribute('$collectionId'); | ||
| $newDocument->removeAttribute('$databaseId'); | ||
| $newDocument->setAttribute('$collection', $collection->getId()); |
There was a problem hiding this comment.
I think we can do this outside the foreach loop
This was referenced Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #5404 Update of document with relations without permissions of relation collection
Test Plan
Added E2E test case
Related PRs and Issues
Checklist