Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add APIs to atomically increment/decrement numeric attributes #5803

Draft
wants to merge 2 commits into
base: 1.4.x
Choose a base branch
from
Draft

Add APIs to atomically increment/decrement numeric attributes #5803

wants to merge 2 commits into from
+592 −6

Conversation

stnguyen90
Copy link
Contributor

What does this PR do?

Fixes #3905

Test Plan

E2E tests added

Related PRs and Issues

  • 3905

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@stnguyen90 stnguyen90 force-pushed the feat-3905-atmomic-update branch from 25063d5 to 9f1f3d6 Compare July 11, 2023 23:31
@stnguyen90 stnguyen90 force-pushed the feat-3905-atmomic-update branch from 9f1f3d6 to c010a67 Compare July 11, 2023 23:32
@stnguyen90 stnguyen90 marked this pull request as ready for review July 12, 2023 01:41
fogelito
fogelito reviewed Jul 12, 2023
View reviewed changes
app/controllers/api/databases.php
}

// Validate attribute type
$attribute = $collection->find('key', $key, 'attributes');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to check the attribute status?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or query for "available"

@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Closed
@stnguyen90 stnguyen90 marked this pull request as draft August 12, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fogelito fogelito fogelito left review comments

@TorstenDittmann TorstenDittmann Awaiting requested review from TorstenDittmann

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stnguyen90 @fogelito