Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: 1.0 bugs from QA (3) #3798

Merged
merged 7 commits into from
Sep 13, 2022
Merged

Fix: 1.0 bugs from QA (3) #3798

merged 7 commits into from
Sep 13, 2022

Conversation

Meldiron
Copy link
Contributor

@Meldiron Meldiron commented Sep 9, 2022 •
edited
Loading

What does this PR do?

  • Implements enabled boolean attribute on functions
  • Fix bug when listVariables returned all variables (not just for a specific function)
  • Remove queries from listVariables endpoint

Test Plan

  • Manual QA

Related PRs and Issues

x

Have you read the Contributing Guidelines on issues?

Yes

eldadfux
eldadfux requested changes Sep 11, 2022
View reviewed changes
app/controllers/api/functions.php Outdated Show resolved Hide resolved
app/controllers/api/functions.php Show resolved Hide resolved
app/controllers/api/functions.php Outdated Show resolved Hide resolved
@Meldiron Meldiron requested a review from eldadfux September 12, 2022 09:02
@christyjacob4 christyjacob4 merged commit b98bbf4 into 0.16.x Sep 13, 2022
@christyjacob4 christyjacob4 mentioned this pull request Sep 13, 2022
Merged
@stnguyen90 stnguyen90 deleted the matej-qa-3 branch February 14, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christyjacob4 christyjacob4 christyjacob4 approved these changes

@eldadfux eldadfux Awaiting requested review from eldadfux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Meldiron @eldadfux @christyjacob4