Proper 409 with customIDs #2652
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christyjacob4
approved these changes
Jan 20, 2022
christyjacob4
approved these changes
Jan 20, 2022
kodumbeats
suggested changes
Jan 20, 2022
tests/e2e/General/HTTPTest.php
Outdated
| @@ -13,6 +13,8 @@ class HTTPTest extends Scope | |||
| use ProjectNone; | |||
| use SideNone; | |||
|
|
|||
| // TODO: We are missing a lof of tests for each create and update endpoint that can take customID. There should be FAILED check with 409 conflict, if ID is already used. | |||
There was a problem hiding this comment.
I don't think leaving a TODO for testing is appropriate. Since we're writing the logic to catch these exceptions, this PR should contain the e2e tests to validate this change.
|
Updated with master again. |
|
@Meldiron some tests are failing. |
|
@Meldiron is this still worth keeping open? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added 409 errors for when using customID. Multiple endpoints were missing this check.
Let's say there is a user with ID (nickname)
meldironand someone else with different emails tries to use the same ID. In the current implementation, that would be aduplicate entry500 error. With this PR, it will throw 409 errors properly.Test Plan
Manual QA:
I added tests for new catches I added
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
✅