Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(locales): Add Polish(pl) translations #1811

Merged
merged 2 commits into from
Oct 5, 2021
Merged

feat(locales): Add Polish(pl) translations #1811

merged 2 commits into from
Oct 5, 2021

Conversation

achromik
Copy link
Contributor

@achromik achromik commented Oct 1, 2021 •
edited
Loading

What does this PR do?

Add Polish (pl) translations

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

#1710

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

christyjacob4
christyjacob4 reviewed Oct 4, 2021
View reviewed changes
Copy link
Member

@christyjacob4 christyjacob4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments

@christyjacob4 christyjacob4 added the hacktoberfest-accepted Accepted for Hacktoberfest, will be merged later label Oct 4, 2021
achromik
achromik commented Oct 4, 2021
View reviewed changes
app/config/locale/translations/pl.json Outdated
"emails.recovery.thanks": "Dziękujemy",
"emails.recovery.signature": "Zespół {{project}}",
"emails.invitation.subject": "Zaproszenie do zespołu %s w %s",
"emails.invitation.hello": "Cześć",
Copy link
Contributor Author

@achromik achromik Oct 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the comma should be at the end, because in English translation there is no comma at the end. All punctuation is based on the English translation file.
https://github.com/appwrite/appwrite/blob/master/app/config/locale/translations/en.json#L25
In Polish translation file, I'm keeping the punctuation 1:1 with the English translation file

@christyjacob4
Copy link
Member

@achromik Yes, you're right . I probably made a mistake with L25 . I actually meant L13 https://github.com/appwrite/appwrite/blob/master/app/config/locale/translations/en.json#L13 and I think you already fixed it.

@christyjacob4 christyjacob4 merged commit bc4970b into appwrite:master Oct 5, 2021
@christyjacob4
Copy link
Member

THANK YOU so much! All changes merged 🥳
Please reach out to me on our Discord server if you would like to claim your Appwrite swag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted for Hacktoberfest, will be merged later
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achromik @christyjacob4