Use a cover image instead of just the logo for visilbilty in dark mode #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnguyen90
commented
Sep 28, 2023
profile/README.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| <br /> | |||
| <p align="center"> | |||
| <a href="https://appwrite.io" target="_blank"><img width="260" height="39" src="https://appwrite.io/images/logos/appwrite-light.svg" alt="Appwrite Logo"></a> | |||
| <a href="https://appwrite.io" target="_blank"><img src="./images/cover.png" alt="Appwrite Logo"></a> | |||
There was a problem hiding this comment.
I'm not sure how GitHub will handle this relative link on the profile page even after reading the docs...
Also move the Console screenshot down so it's not so close to the top banner.
stnguyen90
force-pushed
the
fix-logo
branch
from
5861dfa to
df860b1
Compare
christyjacob4
approved these changes
Sep 28, 2023
Merged
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use a cover image instead of just the logo for visilbilty in dark mode
Test Plan
Manually modified the HTML to test:
Related PRs and Issues
None
Have you read the Contributing Guidelines on issues?
Yes