This repository was archived by the owner on Jun 25, 2019. It is now read-only.
Improved Location, MapOptions & Marker. #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added extra attributes to location class * Extra attributes for location update added to Android invokeMethod in MapViewPlugin.kt
* Added iOS version of extra data for Location updates. * Added extra MapOptions attributes. - showMyLocationButton = show/hide button to center map on user location. - showCompassButton = show/hide button to change orientation of map. - hideToolbar = show/hide toolbar on Map Activity/View. * Added iOS controls for MapOptions Attributes listed above. * FIX: Fixed iOS bug that avoided the location updates and button to show properly.
* Added Android MapOptions attributes controls. * Updated Kotlin version to 1.2.50
Flutter * Added drag event support for markers * Added custom icon support for markers * Updated example to display marker drag usage and custom icon. * Added image to use as marker icon in example. Android * Added marker drag controls * Added methods to get the bitmap from an Flutter asset to be set a custom icon in a marker
Flutter * Added MarkerIcon class to set the image and size of the marker icon. * Updated example to match the changes of the marker class regarding the icon. iOS * Added marker drag controls. * Added methods to set the image asset as the marker icon. * Added MarkerIcon class to match the Flutter plugin changes.
Android * Added MarkerIcon class to match the Flutter plugin changes. * Added resize functionality for custom marker icon.
LJaraCastillo
commented
Jun 22, 2018
example/lib/main.dart
Outdated
| /// - Android Maps API | ||
| /// - iOS Maps API | ||
| const API_KEY = "<your-api-key>"; | ||
| const API_KEY = "AIzaSyDv2UaDTnfXOO5owAG1Vg49ceYAfAYW3xU"; |
There was a problem hiding this comment.
This never happened :) . I changed this key, so it doesn't exist anymore.
LJaraCastillo
commented
Jun 22, 2018
example/lib/main.dart
Outdated
| /// - Static Maps API | ||
| /// - Android Maps API | ||
| /// - iOS Maps API | ||
| const API_KEY = "AIzaSyDv2UaDTnfXOO5owAG1Vg49ceYAfAYW3xU"; |
There was a problem hiding this comment.
Key was removed.
LJaraCastillo
changed the title
Flutter * Bearing added to Location class. * Rotation added to Marker class. * Fix: Clear methods now also clean the flutter reference of the map elements. Android * Added rotation support for Marker. * Bearing added to returned map in "locationUpdated" method callback. iOS * Added rotation support for Marker. * Bearing (course) added to returned map in "locationUpdated" method callback.
Flutter * Added bearing and tilt for camera position. * cameraPositionChanged will now bring bearing and tilt in the returned object. Android * Added bearing and tilt when setting the camera for the map. * Added bearing and tilt to the returned map in the callback (cameraPositionChanged) when the camera is updated. iOS * Incomplete changes regarding camera position update.
iOS * Added camera position changes to use the bearing and tilt sent from flutter.
|
Hi @matthewtsmith any chance to merge it? |
matthewtsmith
approved these changes
Jul 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: