This repository was archived by the owner on Jun 25, 2019. It is now read-only.
Feature/maptype staticmap #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewtsmith
suggested changes
Mar 6, 2018
example/lib/main.dart
Outdated
| cameraPosition = new CameraPosition(Locations.portland, 2.0); | ||
| staticMapUri = staticMapProvider.getStaticUriWithMarkers(_markers, | ||
| maptype: StaticMapViewType.satellite, center: new Location(45.523970, -122.663081)); | ||
| //staticMapUri = staticMapProvider.getStaticUri(Locations.portland, 12, |
There was a problem hiding this comment.
I'd prefer to leave this line uncommented and remove the line you added for testing the "center" attribute.
lib/static_map_provider.dart
Outdated
| static const int defaultZoomLevel = 4; | ||
| static const int defaultWidth = 600; | ||
| static const int defaultHeight = 400; | ||
| static const StaticMapViewType defaultMaptype =StaticMapViewType.roadmap; |
There was a problem hiding this comment.
The formatting in this file looks off. Make sure to run dartfmt on it.
|
@matthewtsmith I have made the changes that you requested. |
|
Hey @matthewtsmith , is any other changes that need to be done for this PR? |
matthewtsmith
approved these changes
Apr 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am submit a PR for this issue #19
Regards,
Helen