Skip to content

Commit

Permalink
Merge pull request #6039 from pedroalvesbatista/fix-linter-final
Browse files Browse the repository at this point in the history
Update linter to the latest functional version
  • Loading branch information
DrDaveD authored Jun 15, 2021
2 parents d514fb8 + 91a71d3 commit 54b4598
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 10 deletions.
1 change: 0 additions & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ linters:
- gosimple
- govet
- ineffassign
- maligned
- misspell
- nakedret
# we would like to add these
Expand Down
13 changes: 5 additions & 8 deletions INSTALL.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,21 +59,18 @@ $ echo 'export GOPATH=${HOME}/go' >> ~/.bashrc && \

This is an optional (but highly recommended!) step. To ensure
consistency and to catch certain kinds of issues early, we provide a
configuration file for golangci-lint. Every pull request must pass the
configuration file for `golangci-lint`. Every pull request must pass the
checks specified there, and these will be run automatically before
attempting to merge the code. If you are modifying Singularity and
contributing your changes to the repository, it's faster to run these
checks locally before uploading your pull request.

In order to install golangci-lint, you can run:
In order to download and install the latest version of `golangci-lint`,
you can run:

```sh
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin
```
$ curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh |
sh -s -- -b $(go env GOPATH)/bin v1.31.0
```

This will download and install golangci-lint from its Github releases
page (using version v1.31.0 at the moment).

## Clone the repo

Expand Down
2 changes: 1 addition & 1 deletion scripts/run-linter
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

set -e

golangci_lint_version=1.31.0
golangci_lint_version=1.40.1
golangci_lint_install_url=https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh

info() {
Expand Down

0 comments on commit 54b4598

Please sign in to comment.