fix: Refresh current user in edit profile#8267
fix: Refresh current user in edit profile#8267sbalaji1192 merged 2 commits intoappsmithorg:releasefrom
Conversation
|
Thanks for opening this pull request! 🤗 Please register for Appsmith Hacktoberfest swag here if you haven't already https://bit.ly/appsmith-hacktoberfest-registration |
|
@Ian-Yy Your fix doesn't solve the issue. Have you tested this changes locally? |
|
Hi @sbalaji1192 . Yes. I've tested this locally and it's working with both display picture and display name. My steps is
Please let me know if there's anything wrong with my steps or fixes. Thanks. P.S.: Edited because just found out display picture has nothing to do with this and there's another endpoint /photo for that |
|
@Ian-Yy Please try with a normal tab and an incognito tab. This issue is only reproducible, when the two tabs don't share a session between them. |
|
@sharat87 Could you please also approve? |
|
/ok-to-test sha=0001eed |
Description
This PR is to fix issue #7217 which user name is not reflected in other instances. This is because in the edit profile page, the user state is not updated. So, I change it so that whenever we enter edit profile, it will update with the latest current user state.
Fixes #7217
Type of change
How Has This Been Tested?
I repeat the same steps as recorded in the issue and I am not sure how to write Cypress/Jest for this. If tests is needed, please guide me on this.
Checklist: