Skip to content

fix: Show button when fetching columns #6891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rishabhrathod01 merged 2 commits into from
Aug 26, 2021
Merged

fix: Show button when fetching columns #6891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7403ada
Fix: Show button when fetching columns
Aug 25, 2021
182a000
fix: commit to fix semantic issue
Aug 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/client/src/components/ads/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ const btnFontStyles = (props: ThemeProp & ButtonProps): BtnFontType => {
};

const ButtonStyles = css<ThemeProp & ButtonProps>`
user-select: none;
width: ${(props) =>
props.width ? props.width : props.fill ? "100%" : "auto"};
height: ${(props) => btnFontStyles(props).height}px;
Expand Down
2 changes: 0 additions & 2 deletions app/client/src/pages/Editor/GeneratePage/components/GeneratePageForm/GeneratePageForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,6 @@ const GENERATE_PAGE_MODE = {
REPLACE_EMPTY: "REPLACE_EMPTY", // current page's content (DSL) is updated to template DSL. (same pageId)
};

//

function GeneratePageSubmitBtn({
disabled,
isLoading,
Expand Down
2 changes: 1 addition & 1 deletion app/client/src/pages/Editor/GeneratePage/components/GeneratePageForm/GoogleSheetForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ function GoogleSheetForm(props: Props) {
</>
) : null}

{selectedSheet.value && columnHeaderList.length
{selectedSheet.value
? renderSubmitButton({
onSubmit,
disabled: !columnHeaderList.length || isFetchingColumnHeaderList,
Expand Down