Skip to content

fix: Show Crud Info Modal data from backend#6879

Closed
rishabhrathod01 wants to merge 2 commits intoreleasefrom
fix/crud-info-modal
Closed

fix: Show Crud Info Modal data from backend#6879
rishabhrathod01 wants to merge 2 commits intoreleasefrom
fix/crud-info-modal

Conversation

@rishabhrathod01
Copy link
Contributor

@rishabhrathod01 rishabhrathod01 commented Aug 25, 2021

Crud Info modal will now have dynamic data for each CRUD template.

Description

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually in local

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🟢 Total coverage has increased
// Code coverage diff between base branch:release and head branch: fix/crud-info-modal 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 55.05 (0.02) 36.97 (0.02) 33.74 (0.03) 55.66 (0.03)
🟢 app/client/src/actions/pageActions.tsx 69.39 (2.72) 25 (0) 28.57 (0) 59.09 (3.38)
🟢 app/client/src/constants/messages.ts 70.2 (0.1) 100 (0) 10.07 (0.32) 77.51 (0.38)
🟢 app/client/src/pages/Editor/GeneratePage/components/CrudInfoModal.tsx 80.39 (2.89) 89.66 (-10.34) 36.36 (9.09) 79.17 (2.25)
🔴 app/client/src/sagas/PageSagas.tsx 23.77 (0) 6.25 (0) 14.29 (0) 25.45 (-0.09)

@rishabhrathod01
Copy link
Contributor Author

Closing this #6882 has all changes.

@rishabhrathod01 rishabhrathod01 added the Duplicate This issue or pull request already exists label Aug 25, 2021
@rishabhrathod01 rishabhrathod01 deleted the fix/crud-info-modal branch August 25, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant