Skip to content

feat: Feature flags snippet and linting features. #6828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sumitsum merged 1 commit into from
Aug 24, 2021
Merged

feat: Feature flags snippet and linting features. #6828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...erver/appsmith-server/src/main/java/com/appsmith/server/featureflags/FeatureFlagEnum.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ public enum FeatureFlagEnum {

// ------------------- These are actual feature flags meant to be used across the product ----------------------- //
JS_EDITOR,
COMMENT;
COMMENT,
SNIPPET,
LINTING;
}

20 changes: 19 additions & 1 deletion app/server/appsmith-server/src/main/resources/features/init-flags.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,22 @@ ff4j:
class: com.appsmith.server.featureflags.strategies.EmailBasedRolloutStrategy
param:
- name: emailDomains
value: appsmith.com,wazirx.com,pharmeasy.in,allround.club
value: appsmith.com,wazirx.com,pharmeasy.in,allround.club

- uid: SNIPPET
enable: true
description: Enable snippets feature by email domain of the user
flipstrategy:
class: com.appsmith.server.featureflags.strategies.EmailBasedRolloutStrategy
param:
- name: emailDomains
value: appsmith.com,moolya.com

- uid: LINTING
enable: true
description: Enable linting feature by email domain of the user
flipstrategy:
class: com.appsmith.server.featureflags.strategies.EmailBasedRolloutStrategy
param:
- name: emailDomains
value: appsmith.com,moolya.com