Skip to content

fix: fixed the DSL migration version after last upgrade#6820

Closed
somangshu wants to merge 3 commits intoreleasefrom
fix/migration-fix-from-menu-widget
Closed

fix: fixed the DSL migration version after last upgrade#6820
somangshu wants to merge 3 commits intoreleasefrom
fix/migration-fix-from-menu-widget

Conversation

@somangshu
Copy link
Contributor

@somangshu somangshu commented Aug 24, 2021

Description

A bug fix, Fixed the migration version, Spawned from #6237

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • NIL
  • On Deploy preview

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🟢 Total coverage has increased
// Code coverage diff between base branch:release and head branch: fix/migration-fix-from-menu-widget 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 54.94 (0.02) 36.88 (0.05) 33.63 (0.03) 55.5 (0.03)
🟢 app/client/src/utils/WidgetPropsUtils.tsx 74.37 (0.34) 66.2 (0) 69.23 (0) 73.45 (0.35)
🟢 app/client/src/utils/autocomplete/TernServer.ts 50.71 (0.24) 38.6 (0.88) 36.21 (0) 55.35 (0.27)
🟢 app/client/src/utils/migrations/MenuButtonWidget.ts 69.23 (46.15) 66.67 (66.67) 100 (100) 66.67 (50)

@riodeuno
Copy link
Contributor

@all-contributors please add @somangshu for bug reports and code

@allcontributors
Copy link
Contributor

@riodeuno

I've put up a pull request to add @somangshu! 🎉

Copy link
Contributor

@rahulramesha rahulramesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for tests

@riodeuno
Copy link
Contributor

@somangshu I believe we can close this PR without merging, as we must have added more migrations after this PR was created, which should have fixed this.

@somangshu somangshu closed this Aug 31, 2021
@somangshu somangshu deleted the fix/migration-fix-from-menu-widget branch August 31, 2021 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants