Added a new type of UIComponent to allow for backward compatibility of UQI forms#6749
Closed
ayushpahwa wants to merge 5 commits intoreleasefrom
Closed
Added a new type of UIComponent to allow for backward compatibility of UQI forms#6749ayushpahwa wants to merge 5 commits intoreleasefrom
ayushpahwa wants to merge 5 commits intoreleasefrom
Conversation
hetunandu
requested changes
Aug 20, 2021
Comment on lines
+203
to
+217
| const allPlugins = getPlugins(state); | ||
| // Adding uiComponent field to switch form type to UQI or allow for backward compatibility | ||
| const plugin = allPlugins.find((plugin) => | ||
| !!formData ? plugin.id === formData.pluginId : false, | ||
| ); | ||
| // Defaults to old value, new value can be DBEditorForm or UQIDBEditorForm | ||
| let uiComponent = UIComponentTypes.DbEditorForm; | ||
| if (plugin) { | ||
| uiComponent = plugin.uiComponent; | ||
| } | ||
|
|
||
| if (uiComponent === UIComponentTypes.UQIDbEditorForm) { | ||
| initFormEvaluations; | ||
| } | ||
|
|
Contributor
Author
|
Too many mismatches due to differences from release. Fixed with #6792 |
auto-merge was automatically disabled
August 24, 2021 10:10
Pull request was closed
mohanarpit
deleted the
feature/6746-backward-compatibility-for-UQI-plugins
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the new UQI system coming in place, this PR is to ensure these changes do not hurt the existing system. This requires a change in the server to update the
uiComponentfield for a plugin toUQIDbEditorForm. Respectively, for the frontend, this value is used to switch between the new method to render or the way to handle currently working forms. The prop type has been edited for the classes to accommodate the new variable.Fixes #6746
Type of change
How Has This Been Tested?
Manual testing
Checklist:
Test coverage results 🧪
🔴 Total coverage has decreased