Skip to content

Added new type to the ActionConfig, fixed some typos #6748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ayushpahwa merged 1 commit into from
Aug 23, 2021
Merged

Added new type to the ActionConfig, fixed some typos #6748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/client/src/entities/Action/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ export enum PaginationType {
export interface ActionConfig {
timeoutInMillisecond?: number;
paginationType?: PaginationType;
formData?: Record<string, unknown>;
pluginSpecifiedTemplates?: Array<{ key?: string; value?: unknown }>;
}

Expand Down
2 changes: 0 additions & 2 deletions app/client/src/pages/Editor/APIEditor/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,6 @@ class ApiEditor extends React.Component<Props> {
settingsConfig={this.props.settingsConfig}
/>
)}

{formUiComponent === "RapidApiEditorForm" && (
<RapidApiEditorForm
apiId={this.props.match.params.apiId}
Expand All @@ -223,7 +222,6 @@ class ApiEditor extends React.Component<Props> {
paginationType={paginationType}
/>
)}

{formUiComponent === "SaaSEditorForm" &&
history.push(
SAAS_EDITOR_API_ID_URL(
Expand Down
4 changes: 2 additions & 2 deletions app/client/src/utils/FormControlFactory.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
ControlData,
} from "components/formControls/BaseControl";

class FormControlFacotory {
class FormControlFactory {
static controlMap: Map<ControlType, ControlBuilder<ControlProps>> = new Map();

static registerControlBuilder(
Expand Down Expand Up @@ -50,4 +50,4 @@ export interface ControlCreationException {
message: string;
}

export default FormControlFacotory;
export default FormControlFactory;