Skip to content

Fix cypress test yml config#6741

Merged
rishabhrathod01 merged 1 commit intoreleasefrom
fix/add-secrets
Aug 19, 2021
Merged

Fix cypress test yml config#6741
rishabhrathod01 merged 1 commit intoreleasefrom
fix/add-secrets

Conversation

@rishabhrathod01
Copy link
Contributor

Pull Request Template

Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description

Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation
and context. List any dependencies that are required for this change.

Fixes # (issue)

if no issue exists, please create an issue and ask the maintainers about this first

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@rishabhrathod01 rishabhrathod01 enabled auto-merge (squash) August 19, 2021 14:01
Copy link
Contributor

@yatinappsmith yatinappsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rishabhrathod01
Copy link
Contributor Author

Merging this as failing test cases are not related and this will resolve issues for #6264

@rishabhrathod01 rishabhrathod01 merged commit a024fb2 into release Aug 19, 2021
@rishabhrathod01 rishabhrathod01 deleted the fix/add-secrets branch August 19, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants