Skip to content

fixed the filter issue in table widget #6739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
somangshu merged 1 commit into from
Aug 23, 2021
Merged

fixed the filter issue in table widget #6739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion app/client/src/widgets/TableWidget/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@ import Skeleton from "components/utils/Skeleton";
import { noop, retryPromise } from "utils/AppsmithUtils";
import withMeta from "../MetaHOC";
import { getDynamicBindings } from "utils/DynamicBindingUtils";
import { ReactTableFilter } from "components/designSystems/appsmith/TableComponent/Constants";
import {
OperatorTypes,
ReactTableFilter,
} from "components/designSystems/appsmith/TableComponent/Constants";
import { TableWidgetProps } from "./TableWidgetConstants";
import derivedProperties from "./parseDerivedProperties";

Expand Down Expand Up @@ -574,6 +577,16 @@ class TableWidget extends BaseWidget<TableWidgetProps, WidgetState> {
// If the user has changed the tableData OR
// The binding has returned a new value
if (tableDataModified && this.props.renderMode === RenderModes.CANVAS) {
// Set filter to default
const defaultFilter = [
{
column: "",
operator: OperatorTypes.OR,
value: "",
condition: "",
},
];
this.applyFilters(defaultFilter);
// Get columns keys from this.props.tableData
const columnIds: string[] = getAllTableColumnKeys(this.props.tableData);
// Get column keys from columns except for derivedColumns
Expand Down