Skip to content

fix: Fix omnibar redirecting to datasource url for empty search results #6696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akash-codemonk merged 5 commits into from
Aug 25, 2021
Merged

fix: Fix omnibar redirecting to datasource url for empty search results #6696

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
287bcc6
Fix omnibar redirecting to datasource url
akash-codemonk Aug 18, 2021
d480ae2
Merge branch 'release' of github.com:appsmithorg/appsmith into fix/om…
akash-codemonk Aug 19, 2021
7f1b4b0
Merge branch 'release' of github.com:appsmithorg/appsmith into fix/om…
akash-codemonk Aug 20, 2021
a8739fc
Merge branch 'release' of github.com:appsmithorg/appsmith into fix/om…
akash-codemonk Aug 23, 2021
d4f454f
Merge branch 'release' of github.com:appsmithorg/appsmith into fix/om…
akash-codemonk Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/client/src/components/editorComponents/GlobalSearch/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,11 @@ function GlobalSearch() {

const handleItemLinkClick = (itemArg?: SearchItem, source?: string) => {
const item = itemArg || activeItem;
const type = getItemType(item) as SEARCH_ITEM_TYPES;
const type = getItemType(item);

// When there is no active item(or no search results) do nothing
// on pressing enter
if (!searchResults.length) return;

AnalyticsUtil.logEvent("NAVIGATE_TO_ENTITY_FROM_OMNIBAR", {
type,
Expand Down