Skip to content

Fix/select widget placeholder #6677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
somangshu merged 4 commits into from
Aug 25, 2021
Merged

Fix/select widget placeholder #6677

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ffe8fe3
fix: add placeholder to select widget
Tooluloope Aug 18, 2021
08114a8
fix: add placeholder to property pane
Tooluloope Aug 18, 2021
66672cf
fix: consistency between select widgets
Tooluloope Aug 23, 2021
99ab75f
Merge branch 'release' into fix/select-widget-placeholder
Tooluloope Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/client/src/components/designSystems/blueprint/DropdownComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ class DropDownComponent extends React.Component<DropDownComponentProps> {
this.props.selectedIndex !== undefined &&
this.props.selectedIndex > -1
? this.props.options[this.props.selectedIndex].label
: "-- Select --"
: this.props.placeholder || "-- Select --"
}
/>
</StyledSingleDropDown>
Expand Down
10 changes: 10 additions & 0 deletions app/client/src/widgets/DropdownWidget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,16 @@ class DropdownWidget extends BaseWidget<DropdownWidgetProps, WidgetState> {
},
dependencies: ["selectionType"],
},
{
helpText: "Input Place Holder",
Comment thread
Tooluloope marked this conversation as resolved.
Outdated
propertyName: "placeholderText",
label: "Placeholder",
controlType: "INPUT_TEXT",
placeholderText: "Enter placeholder text",
isBindProperty: true,
isTriggerProperty: false,
validation: { type: ValidationTypes.TEXT },
},
{
propertyName: "isFilterable",
label: "Filterable",
Expand Down