Skip to content

Fix: show property pane only when respective widget is present on the DOM #6670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marks0351 merged 3 commits into from
Aug 24, 2021
Merged

Fix: show property pane only when respective widget is present on the DOM #6670

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57e4d4d
Fix: show property pane only when respective widget is present on the…
marks0351 Aug 18, 2021
ce3fe01
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
marks0351 Aug 19, 2021
4e70cd2
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
marks0351 Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/client/src/selectors/propertyPaneSelectors.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import { CanvasWidgetsReduxState } from "reducers/entityReducers/canvasWidgetsRe
import { getSelectedWidget, getSelectedWidgets } from "./ui";
import { EVALUATION_PATH } from "utils/DynamicBindingUtils";
import { DataTreeEntity } from "entities/DataTree/dataTreeFactory";
import { generateClassName } from "utils/generators";

export type WidgetProperties = WidgetProps & {
[EVALUATION_PATH]?: DataTreeEntity;
Expand Down Expand Up @@ -163,6 +164,9 @@ export const getIsPropertyPaneVisible = createSelector(
lastSelectedWidget,
widgets,
) => {
const el = document.getElementsByClassName(
generateClassName(pane.widgetId),
)[0];
const isWidgetSelected = pane.widgetId
? lastSelectedWidget === pane.widgetId || widgets.includes(pane.widgetId)
: false;
Expand All @@ -172,6 +176,7 @@ export const getIsPropertyPaneVisible = createSelector(
!multipleWidgetsSelected &&
!isResizingorDragging &&
pane.isVisible &&
el &&
pane.widgetId
);
},
Expand Down