Skip to content

Show lint errors in the debugger#6006

Closed
vnodecg wants to merge 7 commits intoreleasefrom
feature/linting-errors
Closed

Show lint errors in the debugger#6006
vnodecg wants to merge 7 commits intoreleasefrom
feature/linting-errors

Conversation

@vnodecg
Copy link
Contributor

@vnodecg vnodecg commented Jul 20, 2021

Description

We are not showing lint errors in the debugger. This MR addresses this issue

Fixes #5661

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

This has been manually tested

Screen Shot 2021-07-20 at 8 05 39 AM

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased
// Code coverage diff between base branch:release and head branch: feature/linting-errors 
Status File % Stmts % Branch % Funcs % Lines
🔴 total 53.32 (-0.02) 34.73 (-0.03) 31.46 (0) 53.88 (-0.01)
🔴 app/client/src/components/editorComponents/Debugger/index.tsx 87.5 (-1.07) 40 (-10) 84.62 (-7.05) 89.74 (1.17)
🔴 app/client/src/sagas/PostEvaluationSagas.ts 18.06 (-2.41) 0 (0) 0 (0) 22.22 (-1.63)

@vnodecg vnodecg requested a review from hetunandu July 30, 2021 05:42
@vnodecg vnodecg requested a review from hetunandu August 2, 2021 08:52
@akash-codemonk
Copy link
Contributor

duplicate

There are two logs for the same error

@hetunandu
Copy link
Member

duplicate

There are two logs for the same error

Can we do something about this @vnodecg ? I think it is because one is a PARSE error and another is a LINT error

@vnodecg
Copy link
Contributor Author

vnodecg commented Aug 10, 2021

duplicate There are two logs for the same error

Can we do something about this @vnodecg ? I think it is because one is a PARSE error and another is a LINT error

We need to pick out the parse errors. We don't have an automated way right now. We can blacklist some parse errors that are duplicated

@vnodecg vnodecg closed this Aug 10, 2021
@vnodecg
Copy link
Contributor Author

vnodecg commented Aug 10, 2021

Accidentally closed it

@vnodecg vnodecg reopened this Aug 10, 2021
@vnodecg
Copy link
Contributor Author

vnodecg commented Aug 12, 2021

Closing this since we are merging this with #6265

@vnodecg vnodecg closed this Aug 12, 2021
@mohanarpit mohanarpit deleted the feature/linting-errors branch October 8, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Show all property errors in the debugger

3 participants