[perf] Update redux store with only the values that changed#5594
Merged
SatishGandham merged 15 commits intoreleasefrom Jul 20, 2021
Merged
[perf] Update redux store with only the values that changed#5594SatishGandham merged 15 commits intoreleasefrom
SatishGandham merged 15 commits intoreleasefrom
Conversation
…alues in the store.
Contributor
Author
|
/ok-to-test sha=72dc508 |
Contributor
Author
|
/ok-to-test sha=f3ccb70 |
Contributor
Author
|
/ok-to-test sha=08aa224 |
Contributor
Author
|
/ok-to-test sha=4d3d23d |
Contributor
Author
|
/ok-to-test sha=5996b1b |
Contributor
Author
|
/ok-to-test sha=ba51bd2 |
Contributor
Author
|
/ok-to-test sha=af8b872 |
SatishGandham
commented
Jul 15, 2021
Contributor
Author
|
/ok-to-test sha=89533e2 |
somangshu
previously approved these changes
Jul 16, 2021
Contributor
somangshu
left a comment
There was a problem hiding this comment.
Approving to run tests
hetunandu
reviewed
Jul 16, 2021
hetunandu
approved these changes
Jul 16, 2021
Contributor
Author
|
/ok-to-test sha=2a0b816 |
somangshu
approved these changes
Jul 19, 2021
Contributor
Author
|
/ok-to-test sha=1dc5963 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Earlier we used to replace the entire evaluated value in the redux store, now we selectively update only what have changed.
This change prevents unnecessary re-renders of the widgets.
Fixes #5567
Type of change
How Has This Been Tested?
Profiled before and after. Only modified widget is re-rendered.
Checklist:
Test coverage results 🧪
🔴 Total coverage has decreased