Skip to content

fix: Updating the logo in the app editor to use favicon instead #41147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ankitakinger merged 3 commits into from
Jul 29, 2025
Merged

fix: Updating the logo in the app editor to use favicon instead #41147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcce11c
updating the logo in app editor to favicon
ankitakinger Jul 29, 2025
6201f2c
adding additional check for favicon
ankitakinger Jul 29, 2025
29ca678
updating branding favicon size from 32x32 to 48x48
ankitakinger Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/client/src/ce/constants/messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1698,13 +1698,13 @@ export const ADMIN_BRANDING_LOGO_FORMAT_ERROR = () =>
export const ADMIN_BRANDING_LOGO_REQUIREMENT = () =>
`.SVG, .PNG, or .JPG only • Max 2MB`;
export const ADMIN_BRANDING_FAVICON_DIMENSION_ERROR = () =>
`Uploaded file must have a max size of 32X32 pixels`;
`Uploaded file must have a max size of 48X48 pixels`;
export const ADMIN_BRANDING_FAVICON_SIZE_ERROR = () =>
`Uploaded file must be less than 2MB`;
export const ADMIN_BRANDING_FAVICON_FORMAT_ERROR = () =>
`Uploaded file must be in .ICO, .PNG, and .JPG formats`;
export const ADMIN_BRANDING_FAVICON_REQUIREMENT = () =>
`.ICO, .PNG, or .JPG only • Max 32X32`;
`.ICO, .PNG, or .JPG only • Max 48X48`;
export const PROFILE_DISPLAY_PICTURE_REQUIREMENT = () =>
`.ICO, .PNG, or .JPG only • Max 32X32`;
export const ADMIN_BRANDING_COLOR_TOOLTIP_PRIMARY = () =>
Expand Down
7 changes: 4 additions & 3 deletions app/client/src/pages/Editor/AppsmithLink.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ export const StyledLink = styled((props) => {
min-width: 24px;
width: 24px;
height: 24px;
object-fit: contain;
}
`;

Expand All @@ -49,8 +48,10 @@ export const AppsmithLink = () => {
alt="Appsmith logo"
className="t--appsmith-logo"
src={
organizationConfig.brandLogoUrl
? organizationConfig.brandLogoUrl
organizationConfig.brandFaviconUrl &&
organizationConfig.brandFaviconUrl !==
"https://assets.appsmith.com/appsmith-favicon-orange.ico"
? organizationConfig.brandFaviconUrl
: AppsmithLogo
}
/>
Expand Down
4 changes: 2 additions & 2 deletions app/client/src/utils/BrandingUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ import { ASSETS_CDN_URL } from "constants/ThirdPartyConstants";
import { getAssetUrl } from "ee/utils/airgapHelpers";
import { LightModeTheme } from "@appsmith/wds-theming";

const FAVICON_MAX_WIDTH = 32;
const FAVICON_MAX_HEIGHT = 32;
const FAVICON_MAX_WIDTH = 48;
const FAVICON_MAX_HEIGHT = 48;
const DEFAULT_BRANDING_PRIMARY_COLOR = "#E15615";

export const APPSMITH_BRAND_PRIMARY_COLOR =
Expand Down
Loading