Skip to content

fix: Updating logic for reactive actions to fix cyclic dependency issue with App templates and Generate page flow of a DB #41144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ankitakinger merged 3 commits into from
Jul 29, 2025
Merged

fix: Updating logic for reactive actions to fix cyclic dependency issue with App templates and Generate page flow of a DB #41144

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71bdf3e
updating cyclic dependency check for fixing generate page flow for mo…
ankitakinger Jul 28, 2025
9eb4d11
fixing the issue with order fulfillment tracker
ankitakinger Jul 28, 2025
9079357
addressing review comment and adding ENTITY_TYPE should be present ch…
ankitakinger Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/client/src/ce/workers/Evaluation/evaluationUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1197,7 +1197,7 @@ export function getExternalChangedDependencies(
}

export const isDataPath = (
entity: DataTreeEntity,
entity: DataTreeEntity | Partial<DataTreeEntityConfig>,
fullPropertyPath: string,
) => {
if (isWidget(entity)) {
Expand Down
10 changes: 0 additions & 10 deletions app/client/src/ce/workers/common/DependencyMap/utils/getEntityDependenciesByType.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,16 +132,6 @@ export function getJSDependencies(
dependencies = { ...dependencies, [fullPropertyPath]: newDeps };
}

for (const funcName of jsActionConfig.actionNames) {
const func = jsEntity[funcName];

Comment thread
ankitakinger marked this conversation as resolved.
if (func) {
dependencies[`${jsObjectName}.${funcName}.data`] = [
`${jsObjectName}.${funcName}`,
];
}
}

return dependencies;
}
export function getActionDependencies(
Expand Down
65 changes: 39 additions & 26 deletions app/client/src/entities/DependencyMap/DependencyMapUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ import {
getEntityNameAndPropertyPath,
IMMEDIATE_PARENT_REGEX,
isActionConfig,
isDataPath,
isJSActionConfig,
isWidget,
} from "ee/workers/Evaluation/evaluationUtils";
import type { ConfigTree } from "entities/DataTree/dataTreeTypes";
import { isPathDynamicTrigger } from "utils/DynamicBindingUtils";
Expand Down Expand Up @@ -167,10 +169,6 @@ export class DependencyMapUtils {
return false;
}

static isDataPath(path: string) {
return path.endsWith(".data");
}

static detectReactiveDependencyMisuse(
dependencyMap: DependencyMap,
configTree: ConfigTree,
Expand Down Expand Up @@ -213,27 +211,34 @@ export class DependencyMapUtils {
);

for (const dep of transitiveDeps) {
if (this.isTriggerPath(dep, configTree)) {
hasRun = true;
runPath = dep;
}

if (this.isDataPath(dep)) {
hasData = true;
dataPath = dep;
}

if (
hasRun &&
hasData &&
runPath.split(".")[0] === dataPath.split(".")[0]
) {
throw Object.assign(
new Error(
`Reactive dependency misuse: '${node}' depends on both trigger path '${runPath}' and data path '${dataPath}' from the same entity. This can cause unexpected reactivity.`,
),
{ node, triggerPath: runPath, dataPath },
);
const { entityName: depName } = getEntityNameAndPropertyPath(dep);
const entity = configTree[depName];

// to show cyclic dependency errors only for Action calls and not JSObject.body or JSObject
if (entity && entity.ENTITY_TYPE === "ACTION") {
Comment thread
ankitakinger marked this conversation as resolved.
Outdated
if (this.isTriggerPath(dep, configTree)) {
hasRun = true;
runPath = dep;
}

// using the isDataPath function from evalUtils to calculate data paths based on entity type
if (isDataPath(entity, dep)) {
hasData = true;
dataPath = dep;
}

if (
hasRun &&
hasData &&
runPath.split(".")[0] === dataPath.split(".")[0]
) {
throw Object.assign(
new Error(
`Reactive dependency misuse: '${node}' depends on both trigger path '${runPath}' and data path '${dataPath}' from the same entity. This can cause unexpected reactivity.`,
),
{ node, triggerPath: runPath, dataPath },
);
}
}
}
}
Expand All @@ -256,7 +261,15 @@ export class DependencyMapUtils {

if (!entityConfig) return;

if (!isActionConfig(entityConfig) && !isJSActionConfig(entityConfig)) {
if (isWidget(entityConfig)) {
return;
}

// to not calculate transitive dependencies for JSObject.body and JSObject
if (
isJSActionConfig(entityConfig) &&
Comment thread
ankitakinger marked this conversation as resolved.
(current.includes(".body") || !current.includes("."))
) {
return;
}

Expand Down
Loading