-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat: Adding core logic for Reactive Actions in Post evaluations flow #40963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
5235cf4
adding logic for reactive actions in post eval flow
ankitakinger 1d62582
fixing client build issue
ankitakinger b5f9936
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
ankitakinger 0187825
fixing actionProperties.test.ts
ankitakinger 7f5994e
fixing evalTreeWithChanges.test.ts
ankitakinger a83a98e
fixing dataTreeJSAction.test.ts
ankitakinger eec25b7
fixing evaluation.test.ts
ankitakinger b2bf719
minor changes
ankitakinger 82a3ea6
fixing DependencyMap/__tests__/index.test.ts
ankitakinger f56115b
fixing dataTreeEvaluator.test.ts
ankitakinger fa24300
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
ankitakinger 049a8e6
resolving a cyclic dependency
ankitakinger 90280b1
resolving a cyclic dependency
ankitakinger f5235e5
minor change
ankitakinger a3eb005
adding initial state
ankitakinger e9faded
deleting unwanted files
ankitakinger 3ba0270
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
ankitakinger 8dde32e
adding flag check and updating types
ankitakinger e839cbd
adding analytics
ankitakinger 273adeb
reverting TriggerMeta type changes
ankitakinger 35a4e20
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
ankitakinger 101e298
fixing a cyclic dependency
ankitakinger f771e2b
moved evalSubType enum to constants to reduce cyclic dependency
1bc1d3e
splitting a type
ankitakinger d6e378e
Merge branch 'feat/reactive-actions' of https://github.com/appsmithor…
ankitakinger 0e88378
fix: evalSubType imports fixed
dd23613
Merge branch 'feat/reactive-actions' of https://github.com/appsmithor…
3ebef44
imports for evalSubType fixed
c159805
js module instance not reactive issue fixed
564fce2
fix for runBehaviour updates not triggering reactive flow until refresh
ankitakinger b666a59
Merge branch 'feat/reactive-actions' of https://github.com/appsmithor…
ankitakinger b7c967b
fixing updateDependencies to execute newly binded queries in reactive…
ankitakinger 9eaeab8
addressing coderabbitai comments
ankitakinger dad8877
Merge pull request #41014 from appsmithorg/fix/update-dependency-map
ankitakinger 5c2ce16
addressing review comments
ankitakinger 2c1123e
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
ankitakinger d9d2225
removing a piece of code
ankitakinger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import type { CanvasWidgetsReduxState } from "ee/reducers/entityReducers/canvasWidgetsReducer"; | ||
| import type { ActionDataState } from "ee/reducers/entityReducers/actionsReducer"; | ||
| import type DependencyMap from "entities/DependencyMap"; | ||
| import type { MetaState } from "reducers/entityReducers/metaReducer"; | ||
| import type { AppDataState } from "reducers/entityReducers/appReducer"; | ||
| import type { JSCollectionDataState } from "ee/reducers/entityReducers/jsActionsReducer"; | ||
| import type { MetaWidgetsReduxState } from "reducers/entityReducers/metaWidgetsReducer"; | ||
| import type { AppTheme } from "entities/AppTheming"; | ||
| import type { Module } from "ee/constants/ModuleConstants"; | ||
| import type { ModuleInstance } from "ee/constants/ModuleInstanceConstants"; | ||
| import type { LayoutSystemTypes } from "layoutSystems/types"; | ||
| import type { LoadingEntitiesState } from "reducers/evaluationReducers/loadingEntitiesReducer"; | ||
|
|
||
| export interface DataTreeSeed { | ||
| actions: ActionDataState; | ||
| // TODO: Fix this the next time the file is edited | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| editorConfigs: Record<string, any[]>; | ||
| pluginDependencyConfig: Record<string, DependencyMap>; | ||
| widgets: CanvasWidgetsReduxState; | ||
| widgetsMeta: MetaState; | ||
| appData: AppDataState; | ||
| jsActions: JSCollectionDataState; | ||
| theme: AppTheme["properties"]; | ||
| metaWidgets: MetaWidgetsReduxState; | ||
| isMobile: boolean; | ||
| moduleInputs: Module["inputsForm"]; | ||
| moduleInstances: Record<string, ModuleInstance> | null; | ||
| // TODO: Fix this the next time the file is edited | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| moduleInstanceEntities: any; | ||
| layoutSystemType: LayoutSystemTypes; | ||
| loadingEntities: LoadingEntitiesState; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.