fix: revert app computation cache

app/client/src/sagas/EvaluationsSaga.test.ts

@@ -65,14 +65,6 @@ describe("evaluateTreeSaga", () => {
         [select(getCurrentPageDSLVersion), 1],
       ])
       .call(evalWorker.request, EVAL_WORKER_ACTIONS.EVAL_TREE, {
-        cacheProps: {
-          instanceId: "instanceId",
-          appId: "applicationId",
-          pageId: "pageId",
-          appMode: false,
-          timestamp: new Date("11 September 2024").toISOString(),
-          dslVersion: 1,
-        },
         unevalTree: unEvalAndConfigTree,
         widgetTypeConfigMap: undefined,
         widgets: {},
@@ -113,14 +105,6 @@ describe("evaluateTreeSaga", () => {
         [select(getCurrentPageDSLVersion), 1],
       ])
       .call(evalWorker.request, EVAL_WORKER_ACTIONS.EVAL_TREE, {
-        cacheProps: {
-          instanceId: "instanceId",
-          appId: "applicationId",
-          pageId: "pageId",
-          appMode: false,
-          timestamp: new Date("11 September 2024").toISOString(),
-          dslVersion: 1,
-        },
         unevalTree: unEvalAndConfigTree,
         widgetTypeConfigMap: undefined,
         widgets: {},
@@ -170,14 +154,6 @@ describe("evaluateTreeSaga", () => {
         [select(getCurrentPageDSLVersion), 1],
       ])
       .call(evalWorker.request, EVAL_WORKER_ACTIONS.EVAL_TREE, {
-        cacheProps: {
-          instanceId: "instanceId",
-          appId: "applicationId",
-          pageId: "pageId",
-          appMode: false,
-          timestamp: new Date("11 September 2024").toISOString(),
-          dslVersion: 1,
-        },
         unevalTree: unEvalAndConfigTree,
         widgetTypeConfigMap: undefined,
         widgets: {},

app/client/src/sagas/EvaluationsSaga.ts

@@ -77,7 +77,6 @@ import { resetWidgetsMetaState, updateMetaState } from "actions/metaActions";
 import {
   getAllActionValidationConfig,
   getAllJSActionsData,
-  getCurrentPageDSLVersion,
 } from "ee/selectors/entitiesSelector";
 import type { WidgetEntityConfig } from "ee/entities/DataTree/types";
 import type {
@@ -113,12 +112,6 @@ import { evalErrorHandler } from "./EvalErrorHandler";
 import AnalyticsUtil from "ee/utils/AnalyticsUtil";
 import { endSpan, startRootSpan } from "instrumentation/generateTraces";
 import { transformTriggerEvalErrors } from "ee/sagas/helpers";
-import {
-  getApplicationLastDeployedAt,
-  getCurrentApplicationId,
-  getCurrentPageId,
-} from "selectors/editorSelectors";
-import { getInstanceId } from "ee/selectors/organizationSelectors";
 import type {
   AffectedJSObjects,
   EvaluationReduxAction,
@@ -263,26 +256,13 @@ export function* evaluateTreeSaga(
     yield select(getSelectedAppTheme);
 
   log.debug({ unevalTree, configTree: unEvalAndConfigTree.configTree });
-  const instanceId: string = yield select(getInstanceId);
-  const applicationId: string = yield select(getCurrentApplicationId);
-  const pageId: string = yield select(getCurrentPageId);
-  const lastDeployedAt: string = yield select(getApplicationLastDeployedAt);
   const appMode: ReturnType<typeof getAppMode> = yield select(getAppMode);
   const widgetsMeta: ReturnType<typeof getWidgetsMeta> =
     yield select(getWidgetsMeta);
-  const dslVersion: number | null = yield select(getCurrentPageDSLVersion);
 
   const shouldRespondWithLogs = log.getLevel() === log.levels.DEBUG;
 
   const evalTreeRequestData: EvalTreeRequestData = {
-    cacheProps: {
-      appMode,
-      appId: applicationId,
-      pageId,
-      timestamp: lastDeployedAt,
-      instanceId,
-      dslVersion,
-    },
     unevalTree: unEvalAndConfigTree,
     widgetTypeConfigMap,
     widgets,

app/client/src/workers/Evaluation/__tests__/evaluation.test.ts

@@ -18,7 +18,6 @@ import WidgetFactory from "WidgetProvider/factory";
 import { generateDataTreeWidget } from "entities/DataTree/dataTreeWidget";
 import { sortObjectWithArray } from "../../../utils/treeUtils";
 import klona from "klona";
-import { APP_MODE } from "entities/App";
 
 const klonaFullSpy = jest.fn();
 
@@ -578,19 +577,7 @@ describe("DataTreeEvaluator", () => {
   const evaluator = new DataTreeEvaluator(WIDGET_CONFIG_MAP);
 
   it("Checks the number of clone operations in first tree flow", async () => {
-    await evaluator.setupFirstTree(
-      unEvalTree,
-      configTree,
-      {},
-      {
-        appId: "appId",
-        pageId: "pageId",
-        timestamp: "timestamp",
-        appMode: APP_MODE.PUBLISHED,
-        instanceId: "instanceId",
-        dslVersion: 1,
-      },
-    );
+    await evaluator.setupFirstTree(unEvalTree, configTree, {});
     evaluator.evalAndValidateFirstTree();
     // Hard check to not regress on the number of clone operations. Try to improve this number.
     expect(klonaFullSpy).toBeCalledTimes(15);

app/client/src/workers/Evaluation/evalTreeWithChanges.test.ts

@@ -10,7 +10,6 @@ import type { WidgetEntity } from "plugins/Linting/lib/entity/WidgetEntity";
 import type { UpdateDataTreeMessageData } from "sagas/types";
 import DataTreeEvaluator from "workers/common/DataTreeEvaluator";
 import * as evalTreeWithChanges from "./evalTreeWithChanges";
-import { APP_MODE } from "entities/App";
 import { updateEvalProps } from "./helpers";
 export const BASE_WIDGET = {
   widgetId: "randomID",
@@ -190,19 +189,7 @@ describe("evaluateAndGenerateResponse", () => {
   beforeEach(async () => {
     // we are mimicking the first tree evaluation flow here
     evaluator = new DataTreeEvaluator(WIDGET_CONFIG_MAP);
-    await evaluator.setupFirstTree(
-      unEvalTree,
-      configTree,
-      {},
-      {
-        appId: "appId",
-        pageId: "pageId",
-        timestamp: "timestamp",
-        appMode: APP_MODE.PUBLISHED,
-        instanceId: "instanceId",
-        dslVersion: 1,
-      },
-    );
+    await evaluator.setupFirstTree(unEvalTree, configTree, {});
     evaluator.evalAndValidateFirstTree();
     const dataTree = updateEvalProps(evaluator) || {};
 

app/client/src/workers/Evaluation/handlers/evalTree.ts

@@ -73,7 +73,6 @@ export async function evalTree(
     affectedJSObjects,
     allActionValidationConfig,
     appMode,
-    cacheProps,
     forceEvaluation,
     metaWidgets,
     shouldReplay,
@@ -114,7 +113,6 @@ export async function evalTree(
           unevalTree,
           configTree,
           webworkerTelemetry,
-          cacheProps,
         ),
         webworkerTelemetry,
         { description: "during initialisation" },
@@ -166,7 +164,6 @@ export async function evalTree(
           unevalTree,
           configTree,
           webworkerTelemetry,
-          cacheProps,
         ),
         webworkerTelemetry,
         { description: "non-initialisation" },

app/client/src/workers/Evaluation/types.ts

@@ -16,7 +16,6 @@ import type { WorkerRequest } from "ee/workers/common/types";
 import type { DataTreeDiff } from "ee/workers/Evaluation/evaluationUtils";
 import type { APP_MODE } from "entities/App";
 import type { WebworkerSpanData, Attributes } from "instrumentation/types";
-import type { ICacheProps } from "../common/AppComputationCache/types";
 import type { AffectedJSObjects } from "actions/EvaluationReduxActionTypes";
 import type { UpdateActionProps } from "./handlers/types";
 
@@ -35,7 +34,6 @@ export type EvalWorkerASyncRequest<T = any> = WorkerRequest<
 export type EvalWorkerResponse = EvalTreeResponseData | boolean | unknown;
 
 export interface EvalTreeRequestData {
-  cacheProps: ICacheProps;
   unevalTree: unEvalAndConfigTree;
   widgetTypeConfigMap: WidgetTypeConfigMap;
   widgets: CanvasWidgetsReduxState;