Skip to content

fix: update visibility condition for infinite scroll in TableWidgetV2 #40474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rahulbarwal merged 2 commits into from
Apr 30, 2025
Merged

fix: update visibility condition for infinite scroll in TableWidgetV2 #40474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d68a8f8
fix: update visibility condition for infinite scroll in TableWidgetV2
rahulbarwal Apr 29, 2025
cba8275
test: enable server-side pagination in infinite scroll tests
rahulbarwal Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ypress/e2e/Regression/ClientSide/Widgets/TableV2/InfiniteScrollVariableHeightRows_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ describe(

propPane.EnterJSContext("Table data", JSON.stringify(testData));

propPane.TogglePropertyState("Server side pagination", "On");
propPane.TogglePropertyState("Infinite scroll", "On");
});

Expand Down
1 change: 1 addition & 0 deletions app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/Table_InfiniteScroll_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ describe(

it("1. should enable infinite scroll and verify records are loaded automatically when scrolling", () => {
// Enable infinite scroll in the property pane
propPane.TogglePropertyState("Server side pagination", "On");
propPane.TogglePropertyState("Infinite scroll", "On");

// Wait for network call to complete
Expand Down
6 changes: 4 additions & 2 deletions app/client/src/widgets/TableWidgetV2/widget/propertyConfig/contentConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,10 @@ export default [
updateCellEditabilityOnInfiniteScrollChange,
updateSearchSortFilterOnInfiniteScrollChange,
]),
dependencies: ["primaryColumns"],
hidden: () => !Widget.getFeatureFlag(INFINITE_SCROLL_ENABLED),
dependencies: ["primaryColumns", "serverSidePaginationEnabled"],
hidden: (props: TableWidgetProps) =>
!Widget.getFeatureFlag(INFINITE_SCROLL_ENABLED) ||
!props.serverSidePaginationEnabled,
},
{
helpText: createMessage(TABLE_WIDGET_TOTAL_RECORD_TOOLTIP),
Expand Down
Loading