Skip to content

chore: Update type for run behavior for some instances #40393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ankitakinger merged 1 commit into from
Apr 25, 2025
Merged

chore: Update type for run behavior for some instances #40393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/client/src/actions/pluginActionActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import type { EventLocation } from "ee/utils/analyticsUtilTypes";
import type { GenerateDestinationIdInfoReturnType } from "ee/sagas/helpers";
import type { Span } from "instrumentation/types";
import type { EvaluationReduxAction } from "./EvaluationReduxActionTypes";
import type { ActionRunBehaviour } from "PluginActionEditor/constants/PluginActionConstants";
import type { ActionRunBehaviourType } from "PluginActionEditor/constants/PluginActionConstants";

export const createActionRequest = (
payload: Partial<Action>,
Expand Down Expand Up @@ -354,7 +354,7 @@ export const executePageLoadActions = (

export const setActionsRunBehavior = (
actions: Array<{
runBehavior: ActionRunBehaviour;
runBehavior: ActionRunBehaviourType;
id: string;
name: string;
}>,
Expand All @@ -367,7 +367,7 @@ export const setActionsRunBehavior = (

export const setJSActionsRunBehavior = (
actions: Array<{
runBehavior: ActionRunBehaviour;
runBehavior: ActionRunBehaviourType;
id: string;
name: string;
collectionId?: string;
Expand Down
4 changes: 2 additions & 2 deletions app/client/src/api/PageApi.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import type {
import type { DSLWidget } from "WidgetProvider/constants";
import type { FetchApplicationResponse } from "ee/api/ApplicationApi";
import type { APP_MODE } from "entities/App";
import type { ActionRunBehaviour } from "PluginActionEditor/constants/PluginActionConstants";
import type { ActionRunBehaviourType } from "PluginActionEditor/constants/PluginActionConstants";

export interface FetchPageRequest {
pageId: string;
Expand Down Expand Up @@ -70,7 +70,7 @@ export interface SavePageResponseData {
dsl: Partial<DSLWidget>;
messages: string[];
actionUpdates: Array<{
runBehavior: ActionRunBehaviour;
runBehavior: ActionRunBehaviourType;
id: string;
name: string;
collectionId?: string;
Expand Down
4 changes: 2 additions & 2 deletions app/client/src/ce/reducers/entityReducers/actionsReducer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import type {
UpdateActionPropertyActionPayload,
} from "actions/pluginActionActions";
import { klona } from "klona";
import type { ActionRunBehaviour } from "PluginActionEditor/constants/PluginActionConstants";
import type { ActionRunBehaviourType } from "PluginActionEditor/constants/PluginActionConstants";

export interface ActionData {
isLoading: boolean;
Expand Down Expand Up @@ -315,7 +315,7 @@ export const handlers = {
draftMetaState: ActionDataState,
action: ReduxAction<
Array<{
runBehavior: ActionRunBehaviour;
runBehavior: ActionRunBehaviourType;
id: string;
name: string;
}>
Expand Down
6 changes: 3 additions & 3 deletions app/client/src/ce/reducers/entityReducers/jsActionsReducer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
import { set, keyBy, findIndex, unset } from "lodash";
import { create } from "mutative";
import { klona } from "klona";
import type { ActionRunBehaviour } from "PluginActionEditor/constants/PluginActionConstants";
import type { ActionRunBehaviourType } from "PluginActionEditor/constants/PluginActionConstants";

export const initialState: JSCollectionDataState = [];

Expand Down Expand Up @@ -366,7 +366,7 @@ export const handlers = {
action: ReduxAction<{
actionId: string;
collectionId: string;
runBehavior: ActionRunBehaviour;
runBehavior: ActionRunBehaviourType;
}>,
): JSCollectionDataState =>
state.map((a) => {
Expand Down Expand Up @@ -394,7 +394,7 @@ export const handlers = {
state: JSCollectionDataState,
action: ReduxAction<
Array<{
runBehavior: ActionRunBehaviour;
runBehavior: ActionRunBehaviourType;
id: string;
name: string;
collectionId: string;
Expand Down
3 changes: 2 additions & 1 deletion app/client/src/pages/Editor/JSEditor/JSEditorToolbar/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import type { JSAction } from "entities/JSCollection";
import type { DropdownOption } from "@appsmith/ads-old";
import type { ActionRunBehaviourType } from "PluginActionEditor/constants/PluginActionConstants";

export interface OnUpdateSettingsProps {
value: boolean | number | string;
value: ActionRunBehaviourType;
propertyName: string;
action: JSAction;
}
Expand Down