Skip to content

feat: Replace executeOnLoad with runBehavior in backend code#40344

Closed
vivek-appsmith wants to merge 0 commit intoreleasefrom
feat/reactive-actions-run-behaviour
Closed

feat: Replace executeOnLoad with runBehavior in backend code#40344
vivek-appsmith wants to merge 0 commit intoreleasefrom
feat/reactive-actions-run-behaviour

Conversation

@vivek-appsmith
Copy link
Contributor

@vivek-appsmith vivek-appsmith commented Apr 22, 2025

Description

  • Implemented setRunBehavior method in LayoutActionServiceCEImpl
  • Updated all plugin setting.json files to use runBehavior instead of executeOnLoad
  • Changed control type from SWITCH to DROPDOWN for selecting run behavior options

Type of change

  • Feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • This implementation maintains backward compatibility with existing code
  • The executeOnLoad property is still supported but runBehavior takes precedence when available

Checklist:

  • My code follows the style guidelines of the project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

Fixes #40306

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Caution

🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/14593636787
Commit: b6e8dc4
Cypress dashboard.
Tags: @tag.All
Spec:
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/Apps/MongoDBShoppingCart_spec.ts
  2. cypress/e2e/Regression/ClientSide/Autocomplete/JS_AC1_spec.ts
  3. cypress/e2e/Regression/ClientSide/BugTests/Bug14987_spec.js
  4. cypress/e2e/Regression/ClientSide/BugTests/Bug30219_Spect.ts
  5. cypress/e2e/Regression/ClientSide/BugTests/DS_Bug25982_Spec.ts
  6. cypress/e2e/Regression/ClientSide/BugTests/DS_Bugs26410_spec.ts
  7. cypress/e2e/Regression/ClientSide/Fork/ForkAppWithMultipleDS_Spec.ts
  8. cypress/e2e/Regression/ClientSide/Fork/ForkApplicationReconnectModal_spec.ts
  9. cypress/e2e/Regression/ClientSide/FormNativeToRawTests/MongoConversion_spec.ts
  10. cypress/e2e/Regression/ClientSide/IDE/Tabs_Navigation_spec.ts
  11. cypress/e2e/Regression/ClientSide/Linting/BasicLint_spec.ts
  12. cypress/e2e/Regression/ClientSide/OneClickBinding/JSONFormWidget/JSONForm_mongoDB_spec.ts
  13. cypress/e2e/Regression/ClientSide/OneClickBinding/MultiSelectWidget/MultiSelect_MongoDB_spec.ts
  14. cypress/e2e/Regression/ClientSide/OneClickBinding/SelectWidget/mongoDB_spec.ts
  15. cypress/e2e/Regression/ClientSide/OneClickBinding/TableWidget/OneClickBindingMysql_spec.ts
  16. cypress/e2e/Regression/ClientSide/OneClickBinding/TableWidget/Table_MongoDB_spec.ts
  17. cypress/e2e/Regression/ClientSide/PartialImportExport/PartialExport_spec.ts
  18. cypress/e2e/Regression/ClientSide/Refactoring/Refactoring_spec.ts
  19. cypress/e2e/Regression/ClientSide/Widgets/TableV2/server_side_filtering_spec_1.ts
  20. cypress/e2e/Regression/ServerSide/ActionExecution/Block_Execution.ts
  21. cypress/e2e/Regression/ServerSide/GenerateCRUD/MongoURI_Spec.ts
  22. cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL1_Spec.ts
  23. cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL2_Spec.ts
  24. cypress/e2e/Regression/ServerSide/MySQL_Datatypes/Basic_Spec.ts
  25. cypress/e2e/Regression/ServerSide/MySQL_Datatypes/False_Spec.ts
  26. cypress/e2e/Regression/ServerSide/Params/PassingParams_Spec.ts
  27. cypress/e2e/Regression/ServerSide/QueryPane/DSDocs_Spec.ts
  28. cypress/e2e/Regression/ServerSide/QueryPane/EvaluatedValuePopUp_spec.ts
  29. cypress/e2e/Regression/ServerSide/QueryPane/Mongo1_spec.ts
  30. cypress/e2e/Regression/ServerSide/QueryPane/QueryPane_MySQL_Spec.ts
  31. cypress/e2e/Regression/ServerSide/QueryPane/Querypane_Mongo_Spec.js
  32. cypress/e2e/Sanity/Datasources/MsSQLDataSourceStub_spec.js
  33. cypress/e2e/Sanity/Datasources/MySQLDataSourceStub_spec.js
  34. cypress/e2e/Sanity/Datasources/MySQLNoiseTest_spec.js
  35. cypress/e2e/Sanity/Datasources/MySQL_spec.js
List of identified flaky tests.
Tue, 22 Apr 2025 12:44:09 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 22, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Core Query Execution Issues related to the execution of all queries IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Integrations Product Issues related to a specific integration Query Settings Issues related to the settings of all queries Query Widgets & IDE Pod All issues related to Query, JS, Eval, Widgets & IDE Task A simple Todo Enhancement New feature or request labels Apr 22, 2025
@vivek-appsmith vivek-appsmith added the ok-to-test Required label for CI label Apr 22, 2025
@vivek-appsmith
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

@github-actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/14593642377.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 40344.
recreate: .

@github-actions
Copy link

Deploy-Preview-URL: https://ce-40344.dp.appsmith.com

@vivek-appsmith
Copy link
Contributor Author

Taken care already by #40339

@ankitakinger ankitakinger force-pushed the feat/reactive-actions-run-behaviour branch from b6e8dc4 to 5ace9ba Compare April 22, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Query Execution Issues related to the execution of all queries Enhancement New feature or request IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Integrations Product Issues related to a specific integration ok-to-test Required label for CI Query Settings Issues related to the settings of all queries Query Widgets & IDE Pod All issues related to Query, JS, Eval, Widgets & IDE Task A simple Todo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Update all references in backend and replace executeOnLoad with runBehaviour

2 participants