Skip to content

chore: remove klona from evalTreeWithChanges cycles becauses we aren't doing… #40016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vsvamsi1 wants to merge 1 commit into from
Closed

chore: remove klona from evalTreeWithChanges cycles becauses we aren't doing… #40016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions app/client/src/workers/common/DataTreeEvaluator/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,9 +648,8 @@ export default class DataTreeEvaluator {
} {
this.setConfigTree(configTree);

const localUnEvalTree = Object.assign({}, unEvalTree);
const updatedUnEvalTreeJSFunction = this.updateUnEvalTreeJSFunction(
localUnEvalTree,
unEvalTree,
configTree,
);

Expand Down Expand Up @@ -813,10 +812,12 @@ export default class DataTreeEvaluator {
removedPaths?: Array<{ entityId: string; fullpath: string }>;
translatedDiffs?: DataTreeDiff[];
pathsToSkipFromEval?: string[];
isEvalTreeWithChanges?: boolean;
},
) {
const {
dependenciesOfRemovedPaths = [],
isEvalTreeWithChanges,
pathsToSkipFromEval = [],
removedPaths = [],
translatedDiffs = [],
Expand Down Expand Up @@ -855,7 +856,10 @@ export default class DataTreeEvaluator {

// TODO: For some reason we are passing some reference which are getting mutated.
// Need to check why big api responses are getting split between two eval runs
this.oldUnEvalTree = klona(updatedUnEvalTree);
if (!isEvalTreeWithChanges) {
this.oldUnEvalTree = klona(updatedUnEvalTree);
}

this.oldConfigTree = Object.assign({}, this.getConfigTree());
const cloneEndTime = performance.now();

Expand Down Expand Up @@ -886,7 +890,7 @@ export default class DataTreeEvaluator {
updatedValuePaths: string[][],
pathsToSkipFromEval: string[] = [],
): ReturnType<typeof DataTreeEvaluator.prototype.setupUpdateTree> {
const updatedUnEvalTree = Object.assign({}, this.oldUnEvalTree);
const updatedUnEvalTree = this.oldUnEvalTree;

// skipped update local unEvalTree
if (updatedValuePaths.length === 0) {
Expand All @@ -902,6 +906,7 @@ export default class DataTreeEvaluator {
return {
...this.setupTree(updatedUnEvalTree, updatedValuePaths, {
pathsToSkipFromEval,
isEvalTreeWithChanges: true,
}),
jsUpdates: {},
};
Expand Down
Loading