Skip to content

chore: Adjust WDS buttons #39967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ichik merged 2 commits into from
Mar 28, 2025
Merged

chore: Adjust WDS buttons #39967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aafa195
Adjust text size in small WDS button
ichik Mar 28, 2025
c0ce65e
Adjust WDS subtle borders
ichik Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/client/packages/design-system/theming/src/color/src/LightModeTheme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -990,7 +990,7 @@ export class LightModeTheme implements ColorModeTheme {
// Slightly subtler version of accent border, used in outlined buttons
const color = this.bdAccent.clone();

color.oklch.l += 0.35;
color.oklch.l += 0.42;

return color;
}
Expand Down Expand Up @@ -1053,7 +1053,7 @@ export class LightModeTheme implements ColorModeTheme {
// Slightly subtler version of neutral border, used in outlined buttons
const color = this.bdNeutral.clone();

color.oklch.l += 0.35;
color.oklch.l += 0.47;

return color;
}
Expand Down Expand Up @@ -1095,7 +1095,7 @@ export class LightModeTheme implements ColorModeTheme {
}

private get bdPositiveSubtle() {
// Slightly subtler version of negative border, used in outlined buttons
// Slightly subtler version of positive border, used in outlined buttons
const color = this.bdPositive.clone();

color.oklch.l += 0.07;
Expand Down Expand Up @@ -1190,7 +1190,7 @@ export class LightModeTheme implements ColorModeTheme {
// Slightly subtler version of warning border, used in outlined buttons
const color = this.bdWarning.clone();

color.oklch.l += 0.05;
color.oklch.l += 0.06;
color.oklch.c -= 0.05;

return color;
Expand Down
4 changes: 2 additions & 2 deletions app/client/packages/design-system/widgets/src/components/Button/src/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const _Button = (props: ButtonProps, ref: ForwardedRef<HTMLButtonElement>) => {
data-text=""
fontWeight={500}
lineClamp={1}
size={size === "xSmall" ? "footnote" : "body"}
size={size === "xSmall" || size === "small" ? "caption" : "body"}
>
{children}
</Text>
Expand All @@ -48,7 +48,7 @@ const _Button = (props: ButtonProps, ref: ForwardedRef<HTMLButtonElement>) => {
{!Boolean(children) && (
<Text
data-empty-text=""
size={size === "xSmall" ? "footnote" : "body"}
size={size === "xSmall" || size === "small" ? "caption" : "body"}
>
&#8203;
</Text>
Expand Down
Loading