chore: refactor the creation of workspace and application on signup

[nsarupr]

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/14102139310
Commit: b9aa70c
Cypress dashboard.
Tags: @tag.Sanity
Spec:

---

Thu, 27 Mar 2025 09:11:23 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Refactor
  • Streamlined the default setup process for workspaces and applications, ensuring a more consistent and reliable initial configuration for users during authentication.

[coderabbitai]

Walkthrough

This pull request refactors the default application creation process in the authentication success handler. It separates the concerns by extracting the workspace creation logic into a new method (createWorkspaceIfNotExistsAndGetId) that returns a workspace ID, and by introducing a dedicated method (createFirstApplication) for building and saving the default application using that workspace ID.

Changes

File	Change Summary
app/.../AuthenticationSuccessHandlerCE.java	- Refactored createDefaultApplication to delegate workspace creation to createWorkspaceIfNotExistsAndGetId, which returns a workspace ID instead of an Application object. - Added new method createFirstApplication to handle the creation and persistence of the default application based on the workspace ID.

Sequence Diagram(s)

sequenceDiagram
    participant AuthHandler as AuthenticationSuccessHandlerCE
    participant Workspace as createWorkspaceIfNotExistsAndGetId
    participant AppCreator as createFirstApplication
    participant AppService as applicationPageService

    AuthHandler->>Workspace: Call with (defaultWorkspaceId, Authentication)
    Workspace-->>AuthHandler: Return workspaceId
    AuthHandler->>AppCreator: Call with workspaceId
    AppCreator->>AppService: Invoke createApplication()
    AppService-->>AppCreator: Return Application
    AppCreator-->>AuthHandler: Return Application

Loading

Suggested labels

skip-changelog, ok-to-test

Suggested reviewers

• trishaanand
• sharat87
• nidhi-nair

Poem

In our code, a new path is paved,
Workspaces and apps elegantly behaved.
A split in duty, clear and bright,
Leading our logic to soar in flight.
Cheers to the refactor—coding delight! 🚀

Happy merging and cleaner lines ignite!

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

app/server/appsmith-server/src/main/java/com/appsmith/server/authentication/handlers/ce/AuthenticationSuccessHandlerCE.java (2)

357-384: Clean extraction of workspace creation logic

Extracting this logic into a dedicated method improves readability and maintainability. The method now has a clear purpose: to either retrieve an existing workspace ID or create a new one if needed.

Consider adding Javadoc documentation to this method explaining its purpose and return value.

---

386-392: Well-defined application creation method

This extraction nicely encapsulates the logic for creating the first application. The method is focused on a single responsibility and has clear inputs and outputs.

Consider adding Javadoc documentation to this method explaining its purpose and parameters.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e3a4984 and 6d76a65.

📒 Files selected for processing (1)

• app/server/appsmith-server/src/main/java/com/appsmith/server/authentication/handlers/ce/AuthenticationSuccessHandlerCE.java (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: server-unit-tests / server-unit-tests
• GitHub Check: server-spotless / spotless-check

🔇 Additional comments (1)

app/server/appsmith-server/src/main/java/com/appsmith/server/authentication/handlers/ce/AuthenticationSuccessHandlerCE.java (1)

351-355: Good refactoring with improved separation of concerns

The method now delegates to two specialized methods, making the code more modular and easier to maintain. This follows the Single Responsibility Principle well.