chore: Removing feature flag for app IDE new entity explorer by ankitakinger · Pull Request #39912 · appsmithorg/appsmith

ankitakinger · 2025-03-25T17:16:22Z

Description

Removing feature flag for app IDE new entity explorer

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/14125497555
Commit: 589ae54
Cypress dashboard.
Tags: @tag.All
Spec:

Fri, 28 Mar 2025 16:27:15 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

Refactor
- Streamlined UI rendering for page listings, widget views, and explorer displays by eliminating conditional logic based on legacy feature settings.
Chores
- Removed outdated interface elements and context menus to simplify navigation and enhance consistency.
Tests
- Updated configurations to align testing environments with the consolidated UI behavior.

Overall, users will experience a more uniform and efficient interface with improved performance and reduced interface complexity.

coderabbitai · 2025-03-25T17:16:30Z

Walkthrough

This pull request removes the release_ads_entity_item_enabled feature flag from the codebase. The flag is deleted from its constant definitions as well as from test mocks and conditional render logic in UI components. Additionally, several deprecated components—including old list items, page context menus, and widget-related files—are removed along with their export statements. These changes streamline the UI rendering, simplify control flows, and clean up dependencies by eliminating unused feature flags and legacy components.

Changes

File(s)	Change Summary
`app/client/src/ce/entities/FeatureFlag.ts`	Removed `release_ads_entity_item_enabled` from both `FEATURE_FLAG` and `DEFAULT_FEATURE_FLAG_VALUE`.
`app/client/src/ce/pages/AppIDE/components/JSListItem/old/ListItem.tsx` `app/client/src/ce/pages/AppIDE/components/QueryEntityItem/old/ListItem.tsx`	Deleted components (`JSListItem`, `QueryListItem`) along with their associated props/interfaces.
`app/client/src/ee/pages/AppIDE/components/JSListItem/old/ListItem.tsx` `app/client/src/ee/pages/AppIDE/components/QueryEntityItem/old/ListItem.tsx`	Removed export statements re-exporting the old list item components.
`app/client/src/pages/AppIDE/components/JSExplorer/JSSegmentList.tsx` `app/client/src/pages/AppIDE/components/QueryExplorer/QuerySegmentList.tsx`	Eliminated conditional rendering based on feature flags, simplifying rendering to always use the streamlined component.
`app/client/src/pages/AppIDE/components/PageList/ContextMenu/OldPageContextMenu.tsx` `app/client/src/pages/AppIDE/components/PageList/OldPageEntity.tsx`	Removed the legacy Page Context Menu component and export for old page entities.
`app/client/src/pages/AppIDE/components/PageList/PageList.tsx`	Deleted the feature flag check for `release_ads_entity_item_enabled` and directly rendered `PageEntity` components.
`app/client/src/pages/AppIDE/components/UIList/UIList.test.tsx` `app/client/src/pages/AppIDE/layouts/routers/JSEditor/JSRender.test.tsx` `app/client/src/pages/AppIDE/layouts/routers/QueryEditor/QueryRender.test.tsx` `app/client/src/test/testUtils.tsx`	Removed references to `release_ads_entity_item_enabled` from test mocks and configuration objects.
`app/client/src/pages/AppIDE/components/UIList/UIList.tsx`	Removed conditional rendering for `isNewWidgetTreeEnabled` and the associated old widget list component.
`app/client/src/pages/Editor/Explorer/Widgets/OldWidgetEntityList.tsx` `app/client/src/pages/Editor/Explorer/Widgets/WidgetContextMenu.tsx` `app/client/src/pages/Editor/Explorer/Widgets/WidgetEntity.tsx` `app/client/src/pages/Editor/Explorer/Widgets/WidgetIcon.tsx`	Deleted obsolete widget components, including related types, hooks, and interfaces.

Possibly related PRs

chore: Use ADS components in Page List #39570: Updates the Page List component to use ADS components controlled by the same feature flag.
chore: Removing unused files & components #38832: Involves removal of the release_ads_entity_item_enabled flag from FeatureFlag.ts, aligning with changes in this PR.
chore: Remove function calling flag #39790: Removes a similar feature flag (release_fn_calling_enabled) from the same constants file, following a related refactoring pattern.

Suggested labels

skip-changelog, ok-to-test

Suggested reviewers

ApekshaBhosale

Poem

In the code jungle, flags take flight,
Unused lines vanish into the night.
Old components gently say goodbye,
Leaving a leaner codebase soaring high.
Clean and crisp, the logic is anew—
A refactor song for me and you!
🚀✨

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e7b933 and 73e2b59.

📒 Files selected for processing (19)

app/client/src/ce/entities/FeatureFlag.ts (0 hunks)
app/client/src/ce/pages/AppIDE/components/JSListItem/old/ListItem.tsx (0 hunks)
app/client/src/ce/pages/AppIDE/components/QueryEntityItem/old/ListItem.tsx (0 hunks)
app/client/src/ee/pages/AppIDE/components/JSListItem/old/ListItem.tsx (0 hunks)
app/client/src/ee/pages/AppIDE/components/QueryEntityItem/old/ListItem.tsx (0 hunks)
app/client/src/pages/AppIDE/components/JSExplorer/JSSegmentList.tsx (1 hunks)
app/client/src/pages/AppIDE/components/PageList/ContextMenu/OldPageContextMenu.tsx (0 hunks)
app/client/src/pages/AppIDE/components/PageList/OldPageEntity.tsx (0 hunks)
app/client/src/pages/AppIDE/components/PageList/PageList.tsx (1 hunks)
app/client/src/pages/AppIDE/components/QueryExplorer/QuerySegmentList.tsx (1 hunks)
app/client/src/pages/AppIDE/components/UIList/UIList.test.tsx (0 hunks)
app/client/src/pages/AppIDE/components/UIList/UIList.tsx (1 hunks)
app/client/src/pages/AppIDE/layouts/routers/JSEditor/JSRender.test.tsx (0 hunks)
app/client/src/pages/AppIDE/layouts/routers/QueryEditor/QueryRender.test.tsx (0 hunks)
app/client/src/pages/Editor/Explorer/Widgets/OldWidgetEntityList.tsx (0 hunks)
app/client/src/pages/Editor/Explorer/Widgets/WidgetContextMenu.tsx (0 hunks)
app/client/src/pages/Editor/Explorer/Widgets/WidgetEntity.tsx (0 hunks)
app/client/src/pages/Editor/Explorer/Widgets/WidgetIcon.tsx (0 hunks)
app/client/test/testUtils.tsx (0 hunks)

💤 Files with no reviewable changes (15)

app/client/src/ee/pages/AppIDE/components/JSListItem/old/ListItem.tsx
app/client/src/pages/Editor/Explorer/Widgets/WidgetIcon.tsx
app/client/src/pages/AppIDE/components/UIList/UIList.test.tsx
app/client/src/pages/AppIDE/layouts/routers/JSEditor/JSRender.test.tsx
app/client/test/testUtils.tsx
app/client/src/ce/entities/FeatureFlag.ts
app/client/src/ce/pages/AppIDE/components/QueryEntityItem/old/ListItem.tsx
app/client/src/pages/AppIDE/components/PageList/OldPageEntity.tsx
app/client/src/pages/Editor/Explorer/Widgets/OldWidgetEntityList.tsx
app/client/src/ee/pages/AppIDE/components/QueryEntityItem/old/ListItem.tsx
app/client/src/ce/pages/AppIDE/components/JSListItem/old/ListItem.tsx
app/client/src/pages/AppIDE/layouts/routers/QueryEditor/QueryRender.test.tsx
app/client/src/pages/AppIDE/components/PageList/ContextMenu/OldPageContextMenu.tsx
app/client/src/pages/Editor/Explorer/Widgets/WidgetContextMenu.tsx
app/client/src/pages/Editor/Explorer/Widgets/WidgetEntity.tsx

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: client-lint / client-lint
GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
GitHub Check: client-build / client-build
GitHub Check: client-unit-tests / client-unit-tests
GitHub Check: client-prettier / prettier-check

🔇 Additional comments (5)

app/client/src/pages/AppIDE/components/JSExplorer/JSSegmentList.tsx (1)

72-83: Simplified rendering logic looks good.

The code now directly renders the EntityGroupsList component without conditional logic based on feature flags. This aligns with the PR's objective of removing the feature flag for the app IDE new entity explorer, making the code cleaner and more maintainable.

app/client/src/pages/AppIDE/components/QueryExplorer/QuerySegmentList.tsx (1)

63-74: Simplified rendering logic: Feature flag has been removed

The code has been improved by removing the conditional rendering logic based on the feature flag. The component now directly renders EntityGroupsList without the conditional check, which simplifies the codebase and makes it more maintainable.

app/client/src/pages/AppIDE/components/UIList/UIList.tsx (1)

89-89: Simplified widget rendering by removing feature flag

The code now directly renders the UIEntityListTree component when widgets exist, without conditional logic based on a feature flag. This change improves code cleanliness by:

Eliminating conditional rendering

Standardizing on the new widget tree implementation

Removing dependency on deprecated feature flags

app/client/src/pages/AppIDE/components/PageList/PageList.tsx (2)

1-1: Clean import statement by removing feature flag dependencies

The import statement has been simplified by removing the feature flag related imports. This is part of the larger effort to remove the release_ads_entity_item_enabled feature flag from the codebase.

10-18: Component logic simplified by removing conditional rendering

The PageList component has been streamlined to always render PageEntity components without conditional logic based on feature flags. This creates a more maintainable and cleaner implementation.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…horg#39912) ## Description Removing feature flag for app IDE new entity explorer Fixes [appsmithorg#39919](appsmithorg#39919) ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/14125497555> > Commit: 589ae54 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=14125497555&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Fri, 28 Mar 2025 16:27:15 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **Refactor** - Streamlined UI rendering for page listings, widget views, and explorer displays by eliminating conditional logic based on legacy feature settings. - **Chores** - Removed outdated interface elements and context menus to simplify navigation and enhance consistency. - **Tests** - Updated configurations to align testing environments with the consolidated UI behavior. Overall, users will experience a more uniform and efficient interface with improved performance and reduced interface complexity.

removing feature flag for app IDE new entity explorer

73e2b59

github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Mar 25, 2025

adding back deleted file

589ae54

ankitakinger added the ok-to-test Required label for CI label Mar 28, 2025

ankitakinger requested a review from hetunandu March 28, 2025 09:04

github-actions bot added IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo labels Mar 28, 2025

hetunandu approved these changes Apr 1, 2025

View reviewed changes

ankitakinger merged commit 093f006 into release Apr 3, 2025
90 checks passed

ankitakinger deleted the chore/remove-app-ide-ff branch April 3, 2025 06:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Removing feature flag for app IDE new entity explorer#39912

chore: Removing feature flag for app IDE new entity explorer#39912
ankitakinger merged 2 commits intoreleasefrom
chore/remove-app-ide-ff

ankitakinger commented Mar 25, 2025 •

edited by github-actions bot

Loading

Uh oh!

coderabbitai bot commented Mar 25, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ankitakinger commented Mar 25, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ankitakinger commented Mar 25, 2025 •

edited by github-actions bot

Loading

coderabbitai bot commented Mar 25, 2025 •

edited

Loading