chore: Remove 3rd party dependencies from Custom widget#39894
Conversation
WalkthroughThis pull request updates several React templates and the custom widget's default application by modifying CSS styles and the component structures. The changes remove external dependencies by redefining components (e.g., replacing a third-party Button and Card with locally defined functional components and native HTML elements) while adjusting CSS properties for better layout and presentation. These updates are implemented across multiple files to standardize the UI components and event handling in the custom widget. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Button
participant App
participant DOM
User->>Button: Click (Reset/Next Tip)
Button->>App: Trigger state update
App->>DOM: Rerender content with updated tip
DOM-->>User: Display updated UI
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (3)
⏰ Context from checks skipped due to timeout of 90000ms (5)
🔇 Additional comments (18)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/14053738084. |
|
Deploy-Preview-URL: https://ce-39894.dp.appsmith.com |
...ges/Editor/CustomWidgetBuilder/Editor/Header/CodeTemplates/Templates/anvilTemplates/react.ts
Show resolved
Hide resolved
…39894) Fixes appsmithorg#39584 ## Description This was an unnecessary third-party dependency in our code. While we will not prevent anyone from using it in their applications, it is not required in the default templates. Therefore, we are removing it. For further information, please refer to this [conversation](https://theappsmith.slack.com/archives/CGBPVEJ5C/p1742841918575179?thread_ts=1742812032.686439&cid=CGBPVEJ5C). Fixes appsmithorg#39584 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Sanity, @tag.Widget, @tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/14053696768> > Commit: db2573d > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=14053696768&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity, @tag.Widget, @tag.Anvil` > Spec: > <hr>Tue, 25 Mar 2025 09:07:51 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No
Fixes #39584
Description
This was an unnecessary third-party dependency in our code. While we will not prevent anyone from using it in their applications, it is not required in the default templates. Therefore, we are removing it. For further information, please refer to this conversation.
Fixes #39584
or
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Sanity, @tag.Widget, @tag.Anvil"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/14053696768
Commit: db2573d
Cypress dashboard.
Tags:
@tag.Sanity, @tag.Widget, @tag.AnvilSpec:
Tue, 25 Mar 2025 09:07:51 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?