chore: revert optimisations related execute flow

[vsvamsi1]

Reverted the following optimisations:

• Pushed out the sendExecuteAnalyticsEvent from the critical path of returning action's exection result
• Improved the critical Path sendExecuteAnalyticsEvent by running the application mono concurrent to other events

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Caution

🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13947295811
Commit: fda9eaf
Cypress dashboard.
Tags: @tag.All
Spec:
The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/BugTests/DS_Bug26941_Spec.ts

List of identified flaky tests.

---

Wed, 19 Mar 2025 15:43:49 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Refactor
  • Streamlined the processing of analytics events to enhance overall system performance and maintainability, ensuring a more stable and responsive experience for end users.

[coderabbitai]

Walkthrough

The changes modify the getActionExecutionResult and sendExecuteAnalyticsEvent methods in the ActionExecutionSolutionCEImpl class. The getActionExecutionResult method now uses a flatMap operation instead of a map, allowing for a direct call to sendExecuteAnalyticsEvent. In the sendExecuteAnalyticsEvent method, the retrieval of the Application object has been streamlined by eliminating an intermediate Mono variable, directly returning the result from Mono.justOrEmpty(actionDTO.getApplicationId()). No changes were made to public or exported entities.

Changes

File(s)	Change Summary
app/.../ActionExecutionSolutionCEImpl.java	Refactored getActionExecutionResult to use flatMap for better flow and direct invocation of sendExecuteAnalyticsEvent. Streamlined sendExecuteAnalyticsEvent by removing an intermediate Mono variable.

Sequence Diagram(s)

sequenceDiagram
    participant A as ActionExecutionSolutionCEImpl
    participant App as Application Service
    participant U as User Service
    participant P as Page Service
    participant Plugin as Plugin Service
    participant Env as Environment Service

    A->>A: Initiate sendExecuteAnalyticsEvent
    A->>App: Get Application using applicationId
    App-->>A: Return Application (or new instance)
    A->>U: Fetch Current User
    A->>P: Fetch Page Name
    A->>Plugin: Fetch Plugin Data
    A->>Env: Fetch Environment Name
    A->>A: Combine results and process analytics event

Loading

Possibly related PRs

• feat: added properties for executeAction mixpanel event (#35291) #35645: The changes in the main PR are related to the modifications in the ActionExecutionSolutionCEImpl class, specifically regarding the sendExecuteAnalyticsEvent method, which has been enhanced to include additional parameters for analytics tracking.

Suggested labels

Bug, Task

Suggested reviewers

• dvj1988
• ApekshaBhosale

Poem

In the code where logic flows,
A refactor made its grand debut,
Chaining calls without a fuss,
Clean and clear—they now accrue,
Here’s to neat async magic anew!
🚀😄

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between b9b56d2 and fda9eaf.

📒 Files selected for processing (1)

• app/server/appsmith-server/src/main/java/com/appsmith/server/solutions/ce/ActionExecutionSolutionCEImpl.java (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• app/server/appsmith-server/src/main/java/com/appsmith/server/solutions/ce/ActionExecutionSolutionCEImpl.java

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: perform-test / rts-build / build
• GitHub Check: perform-test / client-build / client-build
• GitHub Check: perform-test / server-build / server-unit-tests
• GitHub Check: server-unit-tests / server-unit-tests
• GitHub Check: server-spotless / spotless-check

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Failed server tests

• com.appsmith.server.git.ServerSchemaMigrationEnforcerTest#saveGitRepo_ImportAndThenExport_diffOccurs