Skip to content

chore: Remove function calling flag #39790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nidhi-nair merged 1 commit into from
Mar 18, 2025
Merged

chore: Remove function calling flag #39790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/client/src/ce/entities/FeatureFlag.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ export const FEATURE_FLAG = {
"release_external_saas_plugins_enabled",
release_tablev2_infinitescroll_enabled:
"release_tablev2_infinitescroll_enabled",
release_fn_calling_enabled: "release_fn_calling_enabled",
} as const;

export type FeatureFlag = keyof typeof FEATURE_FLAG;
Expand Down Expand Up @@ -98,7 +97,6 @@ export const DEFAULT_FEATURE_FLAG_VALUE: FeatureFlags = {
release_ads_entity_item_enabled: false,
release_external_saas_plugins_enabled: false,
release_tablev2_infinitescroll_enabled: false,
release_fn_calling_enabled: false,
};

export const AB_TESTING_EVENT_KEYS = {
Expand Down
6 changes: 3 additions & 3 deletions app/client/src/components/editorComponents/JSResponseView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ import { StateInspector } from "./Debugger/StateInspector";
import { getErrorCount } from "selectors/debuggerSelectors";
import { getIDETypeByUrl } from "ee/entities/IDE/utils";
import { useLocation } from "react-router";
import { getReleaseFnCallingEnabled } from "layoutSystems/anvil/integrations/selectors";
import { getIsAnvilEnabledInCurrentApplication } from "layoutSystems/anvil/integrations/selectors";
import { Visualization } from "PluginActionEditor/components/PluginActionResponse/components/Visualization";

const ResponseTabWrapper = styled.div`
Expand Down Expand Up @@ -214,7 +214,7 @@ function JSResponseView(props: Props) {

const ideViewMode = useSelector(getIDEViewMode);
const location = useLocation();
const isFnCallingEnabled = useSelector(getReleaseFnCallingEnabled);
const isAnvilEnabled = useSelector(getIsAnvilEnabledInCurrentApplication);
Copy link
Contributor

@znamenskii-ilia znamenskii-ilia Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should getIsAnvilLayoutEnabled if you want to check release_anvil_enabled flag

Copy link
Contributor Author

@nidhi-nair nidhi-nair Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current app check is required because you might be have anvil enabled but be working with a non-anvil app as well right?

Copy link
Contributor

@znamenskii-ilia znamenskii-ilia Mar 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid point. Let's keep it and and use getIsAnvilLayoutEnabled if we need to show the tab only if release_anvil_enabled: true


const ideType = getIDETypeByUrl(location.pathname);

Expand All @@ -227,7 +227,7 @@ function JSResponseView(props: Props) {
},
];

if (isFnCallingEnabled) {
if (isAnvilEnabled) {
responseTabs.push({
key: DEBUGGER_TAB_KEYS.VISUALIZATION_TAB,
title: "AI Response Visualizer",
Expand Down
4 changes: 0 additions & 4 deletions app/client/src/layoutSystems/anvil/integrations/selectors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ export const getIsAnvilLayoutEnabled = (state: AppState) => {
return selectFeatureFlagCheck(state, FEATURE_FLAG.release_anvil_enabled);
};

export const getReleaseFnCallingEnabled = (state: AppState) => {
return selectFeatureFlagCheck(state, FEATURE_FLAG.release_fn_calling_enabled);
};

/**
* A selector to verify if the current application is an Anvil application.
* This is done by getting the layout system type of the current application (getLayoutSystemType)
Expand Down
1 change: 0 additions & 1 deletion app/client/src/utils/hooks/useFeatureFlagOverride.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import {
export const AvailableFeaturesToOverride: FeatureFlag[] = [
"release_anvil_enabled",
"release_layout_conversion_enabled",
"release_fn_calling_enabled",
];
export type OverriddenFeatureFlags = Partial<Record<FeatureFlag, boolean>>;

Expand Down
Loading