Skip to content

chore: remove redundant flag#39749

Merged
KelvinOm merged 1 commit intoreleasefrom
chore/remove-redundant-flag
Mar 17, 2025
Merged

chore: remove redundant flag#39749
KelvinOm merged 1 commit intoreleasefrom
chore/remove-redundant-flag

Conversation

@KelvinOm
Copy link
Collaborator

@KelvinOm KelvinOm commented Mar 17, 2025

Description

Just remove flag that we don't need anymore.

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13899733531
Commit: d9702b3
Cypress dashboard.
Tags: @tag.Sanity
Spec:


Mon, 17 Mar 2025 13:25:45 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Refactor
    • Removed an experimental layout toggle from the page header, resulting in a cleaner user interface.
    • Cleaned up related configuration settings to streamline system behavior.

@KelvinOm KelvinOm requested a review from riodeuno March 17, 2025 12:42
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 17, 2025

Walkthrough

This pull request removes the release_anvil_toggle_enabled feature flag and its related logic from the application. The flag is deleted from the feature flag definitions and the default values in FeatureFlag.ts, removed from the list of overrideable features in useFeatureFlagOverride.ts, and its corresponding UI imports and toggle logic are eliminated from the PageHeader.tsx component.

Changes

Files Change Summary
app/client/src/ce/entities/FeatureFlag.ts
app/client/src/utils/hooks/useFeatureFlagOverride.ts
Removed the release_anvil_toggle_enabled flag from the feature flag constants (FEATURE_FLAG, DEFAULT_FEATURE_FLAG_VALUE) and from the AvailableFeaturesToOverride array.
app/client/src/pages/common/PageHeader.tsx Removed imports, conditional logic, and UI elements (including functions and JSX for the Anvil toggle) related to the release_anvil_toggle_enabled feature flag.

Possibly related PRs

Suggested labels

skip-changelog, Enhancement, Task, Anvil Pod, Anvil team, Widgets & Accelerators Pod

Suggested reviewers

  • jacquesikot
  • ApekshaBhosale
  • sharat87

Poem

The flag has flown, its duty done,
Code now shines with clutter none.
Gone are toggles of old display,
A sleeker path now leads the way.
Cheers to clean code and a brighter day!

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ab9bd10 and d9702b3.

📒 Files selected for processing (3)
  • app/client/src/ce/entities/FeatureFlag.ts (0 hunks)
  • app/client/src/pages/common/PageHeader.tsx (0 hunks)
  • app/client/src/utils/hooks/useFeatureFlagOverride.ts (0 hunks)
💤 Files with no reviewable changes (3)
  • app/client/src/pages/common/PageHeader.tsx
  • app/client/src/utils/hooks/useFeatureFlagOverride.ts
  • app/client/src/ce/entities/FeatureFlag.ts
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: perform-test / client-build / client-build
  • GitHub Check: perform-test / rts-build / build
  • GitHub Check: perform-test / server-build / server-unit-tests
  • GitHub Check: client-unit-tests / client-unit-tests
  • GitHub Check: client-prettier / prettier-check
  • GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
  • GitHub Check: client-lint / client-lint
  • GitHub Check: client-build / client-build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@KelvinOm KelvinOm requested a review from jsartisan March 17, 2025 12:42
@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Mar 17, 2025
@KelvinOm KelvinOm added the ok-to-test Required label for CI label Mar 17, 2025
@KelvinOm KelvinOm merged commit 3705176 into release Mar 17, 2025
47 checks passed
@KelvinOm KelvinOm deleted the chore/remove-redundant-flag branch March 17, 2025 13:29
@coderabbitai coderabbitai bot mentioned this pull request Mar 18, 2025
2 tasks
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this pull request Apr 12, 2025
## Description
Just remove flag that we don't need anymore.

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13899733531>
> Commit: d9702b3
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13899733531&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Mon, 17 Mar 2025 13:25:45 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Removed an experimental layout toggle from the page header, resulting
in a cleaner user interface.
- Cleaned up related configuration settings to streamline system
behavior.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants