chore: Missed adding argument for cookie init

[nidhi-nair]

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Refactor
  • Improved session cookie handling by using contextual web exchange data to properly configure secure cookie attributes, ensuring reliable session management.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The update modifies the setSessionId method in CustomCookieWebSessionIdResolverCE to pass a ServerWebExchange parameter to the addCookieInitializers method. The method signature of addCookieInitializers is updated accordingly. This change enables the method to use the exchange context when setting cookie properties (e.g., SameSite attribute as "Lax", secure flag) without altering the overall cookie initialization logic.

Changes

File	Change Summary
app/.../CustomCookieWebSessionIdResolverCE.java	Updated setSessionId to pass a ServerWebExchange parameter and revised addCookieInitializers method signature to accept the exchange.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Resolver as CustomCookieWebSessionIdResolverCE
    participant CookieHandler as CookieInitializer Logic
    Client->>Resolver: Invoke setSessionId(sessionId, exchange)
    Resolver->>Resolver: Call addCookieInitializers(exchange)
    Resolver->>CookieHandler: Initialize cookie (SameSite="Lax", secure)
    CookieHandler-->>Resolver: Cookie initialized
    Resolver-->>Client: Session ID set with cookies configured

Loading

Possibly related PRs

• chore: Custom cooke resolver and logout on session invalidation #39695: Modifications in the CustomCookieWebSessionIdResolverCE class affect extended functionality in CustomCookieWebSessionIdResolver, indicating a direct code-level connection.

Suggested labels

Bug, ok-to-test

Suggested reviewers

• sharat87

Poem

In the code realm, changes shine bright,
Passing the exchange with precise might.
Methods now share context clear,
Cookies secure and details near.
A tweak in flow with a coder’s delight!
🚀 Happy coding!

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 82e9754 and 37a7381.

📒 Files selected for processing (1)

• app/server/appsmith-server/src/main/java/com/appsmith/server/configurations/ce/CustomCookieWebSessionIdResolverCE.java (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.