Skip to content

chore: use margin instead of padding in WDS textarea #39551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsartisan merged 1 commit into from
Mar 4, 2025
Merged

chore: use margin instead of padding in WDS textarea #39551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions app/client/packages/design-system/widgets/src/components/TextArea/src/TextArea.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,12 @@ export function TextArea(props: TextAreaProps) {

const computedStyle = getComputedStyle(input);
const height = parseFloat(computedStyle.height) || 0;
const paddingTop = parseFloat(computedStyle.paddingTop);
const paddingBottom = parseFloat(computedStyle.paddingBottom);
const marginTop = parseFloat(computedStyle.marginTop);
const marginBottom = parseFloat(computedStyle.marginBottom);

setTextFieldHeight(height + paddingTop + paddingBottom);
setTextFieldHeight(height + marginTop + marginBottom);

input.style.height = `${
// subtract comptued padding and border to get the actual content height
input.scrollHeight - paddingTop - paddingBottom
}px`;
input.style.height = `${input.scrollHeight}px`;
input.style.overflow = prevOverflow;
input.style.alignSelf = prevAlignment;
}
Expand Down