CI: Enabled server unit tests on TBD#39539
Conversation
WalkthroughThe pull request introduces a fully defined Changes
Sequence Diagram(s)sequenceDiagram
participant BD as Build Docker Image
participant SU as Server Unit Tests
participant CTR as CI Test Result
participant PM as Package Master
BD->>SU: Complete build triggers unit tests
SU->>CTR: Send test results for CI evaluation
SU->>PM: Notify packaging process
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
btsgh
left a comment
btsgh
left a comment
There was a problem hiding this comment.
Server unit tests are re-enabled.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/test-build-docker-image.yml (1)
125-134: Ensure Consistent Input Types for Server Unit Tests JobThe new
server-unit-testsjob is well integrated into the workflow by depending onbuild-docker-imageand conditionally running based on branch and event type. However, static analysis indicates that the inputsskip-testsandis-pg-buildare expected as strings (per the reusable workflow definition inserver-build.yml), but boolean values are being provided. To avoid any type mismatches at runtime, please update them so that their values are explicitly quoted. For example:- skip-tests: false - is-pg-build: ${{ github.ref == 'refs/heads/pg' }} + skip-tests: "false" + is-pg-build: "${{ github.ref == 'refs/heads/pg' }}"🧰 Tools
🪛 actionlint (1.7.4)
133-133: input "skip-tests" is typed as string by reusable workflow "./.github/workflows/server-build.yml". bool value cannot be assigned
(expression)
134-134: input "is-pg-build" is typed as string by reusable workflow "./.github/workflows/server-build.yml". bool value cannot be assigned
(expression)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/test-build-docker-image.yml(5 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/test-build-docker-image.yml
133-133: input "skip-tests" is typed as string by reusable workflow "./.github/workflows/server-build.yml". bool value cannot be assigned
(expression)
134-134: input "is-pg-build" is typed as string by reusable workflow "./.github/workflows/server-build.yml". bool value cannot be assigned
(expression)
🔇 Additional comments (2)
.github/workflows/test-build-docker-image.yml (2)
282-293: Enhance Test Outcome Reporting in UI Matrix StepThe conditional logic in the "Return status for ui-matrix" step now factors in the outcome of the server unit tests. This ensures that if the server unit tests are skipped or fail, the overall status properly reflects that, which is an improvement in CI feedback. Please verify that the intended behavior of failing on skipped or failed server tests aligns with the overall test strategy.
397-398: Update Package-Master Job DependenciesThe
package-masterjob now depends onserver-unit-testsin addition toci-testandclient-unit-tests. This update ensures that the image packaging only proceeds after all relevant tests pass, meeting the PR objective to incorporate server unit tests into the CI pipeline.
2 participants
Description
Enabled server unit tests on TBD
Fixes #
Issue NumberAutomation
/ok-to-test tags=""
🔍 Cypress test results
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
Tests
Chores