chore: git tag - versioned list for consumed packages in app by brayn003 · Pull Request #39532 · appsmithorg/appsmith

brayn003 · 2025-03-03T18:37:39Z

Description

Adds LeftPane component for listing packages with version dropdowns

Fixes #38810
Fixes #38813

Automation

/ok-to-test tags="@tag.Git,@tag.Module,@tag.IDE"

🔍 Cypress test results

Warning

Tests have not run on the HEAD a2dface yet

Wed, 05 Mar 2025 16:36:30 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

Refactor
- Revised header components to now optionally display descriptive text, enhancing context and alignment.
Style
- Updated button styling for add-library actions for improved visual cues.
- Refined spacing and padding in library listings for a cleaner, more balanced layout.
- Introduced minimum height for certain container components to enhance layout consistency.

coderabbitai · 2025-03-03T18:37:47Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes refactor and enhance UI components by updating the PaneHeader to use a renamed interface (PaneHeaderProps) with an added optional desc prop, modifying its layout to use the Flex component, and adjusting conditional rendering for the description. Additionally, the AddLibraryPopover updates the Button prop from "tertiary" to "secondary", and minor styling adjustments (padding and margin) are applied in the Libraries index file. The JSLibrariesSection now passes a descriptive string to the updated PaneHeader.

Changes

File(s)	Change Summary
`app/client/src/IDE/.../PaneHeader.tsx` `app/client/src/pages/AppIDE/.../JSLibrariesSection.tsx`	Renamed interface from `Props` to `PaneHeaderProps`, added an optional `desc` prop, refactored layout from a styled `div` to using `Flex`, and updated rendering logic to conditionally display the description.
`app/client/src/pages/AppIDE/.../AddLibraryPopover.tsx`	Changed the Button’s `kind` property value from `"tertiary"` to `"secondary"`, affecting its styling and behavior for popover activation.
`app/client/src/pages/Editor/.../Libraries/index.tsx`	Adjusted styling in the `Library` and `Version` components by modifying padding and margin values to refine layout spacing.
`app/client/src/git/components/SettingsModal/.../TabBranch/index.tsx` `app/client/src/git/components/SettingsModal/.../TabGeneral/index.tsx`	Added `min-height: 300px;` to the `Container` styled component, ensuring a minimum height for layout consistency.

Sequence Diagram(s)

sequenceDiagram
    participant JSS as JSLibrariesSection
    participant PH as PaneHeader
    participant Flex as Flex Layout

    JSS->>PH: Render with title, desc, rightIcon
    PH->>PH: Evaluate if 'desc' exists
    alt Description provided
        PH->>Flex: Render title & description layout
    else
        PH->>Flex: Render title only
    end

Possibly related PRs

chore: Split library side pane for adding package control section #36926 – The changes in the main PR, specifically the refactor of the PaneHeader component to include a new desc prop, are related to the modifications in the JSLibrariesSection component where the PaneHeader is updated to include this new desc prop.
chore: Transitions for IDE #35714 – The changes in the main PR involve refactoring the PaneHeader component and adding a new desc prop, which are related to the modifications made in the JSLibrariesSection component.
chore: Update JS Editor Run designs #36998 – The changes in the main PR, specifically the refactor of the PaneHeader component and the addition of the desc prop, are directly related to the modifications made in the JSLibrariesSection component.

Suggested labels

Enhancement, IDE Product

Suggested reviewers

sagar-qa007
ApekshaBhosale
ankitakinger

Poem

In a world of code both crisp and neat,
The header got a tale to tell so sweet.
With Flex aligning every bit just right,
New props dance into view with light.
CodeRabbit cheers as our components take flight! 🚀

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

ashit-rath · 2025-03-04T03:43:04Z

/build-deploy-preview skip-tests=true

github-actions · 2025-03-04T03:43:27Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/13645775138.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 39532.
recreate: .

github-actions · 2025-03-04T03:54:54Z

Deploy-Preview-URL: https://ce-39532.dp.appsmith.com

ashit-rath · 2025-03-04T04:34:41Z

@brayn003 Can you share me the designs you followed to make these changes?

brayn003 · 2025-03-04T10:44:40Z

https://www.figma.com/design/Z0QsSdGOydURn6WIMQ3rHM/Appsmith-Reusability?node-id=6816-317980&t=weHCXcGg8590OMTS-0

…git-tag-2

chore: improving ui for js libs

d01e752

brayn003 requested a review from ashit-rath March 3, 2025 18:37

brayn003 self-assigned this Mar 3, 2025

github-actions bot added Git Product Issues related to version control product Packages & Git Pod All issues belonging to Packages and Git Task A simple Todo labels Mar 3, 2025

brayn003 added the ok-to-test Required label for CI label Mar 3, 2025

github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Mar 3, 2025

Rudraprasad Das added 3 commits March 4, 2025 12:41

Merge branch 'release' of github.com:appsmithorg/appsmith into chore/…

8b1c6e9

…git-tag-2

chore: adding min height to settings

ec10d2a

chore: remove changes made to styles

a2dface

brayn003 removed the request for review from ashit-rath March 4, 2025 20:09

brayn003 removed the ok-to-test Required label for CI label Mar 4, 2025

brayn003 marked this pull request as draft March 4, 2025 20:09

brayn003 force-pushed the chore/git-tag-2 branch from efbcbed to a2dface Compare March 5, 2025 16:35

brayn003 closed this Mar 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: git tag - versioned list for consumed packages in app#39532

chore: git tag - versioned list for consumed packages in app#39532
brayn003 wants to merge 4 commits intoreleasefrom
chore/git-tag-2

brayn003 commented Mar 3, 2025 •

edited by github-actions bot

Loading

Uh oh!

coderabbitai bot commented Mar 3, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

ashit-rath commented Mar 4, 2025

Uh oh!

github-actions bot commented Mar 4, 2025

Uh oh!

github-actions bot commented Mar 4, 2025

Uh oh!

ashit-rath commented Mar 4, 2025

Uh oh!

brayn003 commented Mar 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

brayn003 commented Mar 3, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

ashit-rath commented Mar 4, 2025

Uh oh!

github-actions bot commented Mar 4, 2025

Uh oh!

github-actions bot commented Mar 4, 2025

Uh oh!

ashit-rath commented Mar 4, 2025

Uh oh!

brayn003 commented Mar 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

brayn003 commented Mar 3, 2025 •

edited by github-actions bot

Loading

coderabbitai bot commented Mar 3, 2025 •

edited

Loading