Skip to content

fix:codeowners file#39447

Merged
KelvinOm merged 2 commits intoreleasefrom
fix/codeowners-file
Feb 26, 2025
Merged

fix:codeowners file#39447
KelvinOm merged 2 commits intoreleasefrom
fix/codeowners-file

Conversation

@KelvinOm
Copy link
Collaborator

@KelvinOm KelvinOm commented Feb 26, 2025

Description

Github changes

PR changes

  • Moved WDS widgets from src/modules/ui-builder/ui/wds to src/widgets/wds
  • Updated the paths in CODEOWNERS file
  • In CODEOWNERS @appsmithorg/anvil-team replaced with @appsmithorg/ai-agents-pod.

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13542264374
Commit: 9c5265b
Cypress dashboard.
Tags: @tag.All
Spec:


Wed, 26 Feb 2025 12:06:53 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Chores
    • Updated internal code ownership assignments to better reflect team responsibilities.
  • Refactor
    • Standardized and streamlined internal module imports across UI components and widgets.
    • Removed an outdated component export to optimize the code organization.

@KelvinOm KelvinOm requested review from vivek-appsmith and removed request for a team February 26, 2025 09:53
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 26, 2025

Walkthrough

This pull request primarily restructures team ownership and standardizes module imports. The CODEOWNERS file has been updated with new file patterns and ownership assignments, while numerous files across tests, layout systems, and widget components have their import paths changed from the old "modules/ui-builder/ui/wds" structure to the new "widgets/wds" structure. Additionally, one component export file has been removed to reflect the updated module organization.

Changes

File(s) Change Summary
CODEOWNERS Updated ownership rules with new file patterns (e.g., adding /*), reassigning responsibilities to teams such as @appsmithorg/ai-agents-fe and @appsmithorg/wds-team, and removing outdated comments and assignments.
app/client/{cypress,src/PluginActionEditor,WidgetProvider,layoutSystems,selectors}/… Modified import statements across various files (including tests, sagas, hooks, and utility modules) to change paths from modules/ui-builder/ui/wds to widgets/wds without affecting logic.
app/client/src/components/wds/index.tsx Deleted file that previously exported the Checkbox component, affecting any imports relying on it.
app/client/src/widgets{,/wds}/… Refactored numerous widget files to update import paths for constants, types, and components from modules/ui-builder/ui/wds to the new widgets/wds structure, including minor adjustments like changing a relative import from "components/wds" to "./Checkbox".

Possibly related PRs

Suggested labels

Task, skip-changelog

Suggested reviewers

  • ApekshaBhosale
  • riodeuno

In the realm of code where changes unfold,
Imports realign, shining bright and bold.
Ownership restructures in a neat new way,
Paths streamlined for a smoother day.
Cheers to the updates—jubilant and clear! 🚀
CodeRabbit teams celebrate with a happy cheer!


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d7aac20 and 9c5265b.

📒 Files selected for processing (1)
  • CODEOWNERS (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: perform-test / client-build / client-build
  • GitHub Check: perform-test / server-build / server-unit-tests
  • GitHub Check: perform-test / rts-build / build
  • GitHub Check: client-unit-tests / client-unit-tests
  • GitHub Check: client-lint / client-lint
  • GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
  • GitHub Check: client-build / client-build
  • GitHub Check: client-prettier / prettier-check
🔇 Additional comments (6)
CODEOWNERS (6)

6-8: Clear documentation added for maintenance

Good addition of explanatory comments about path validation before deletion, especially regarding EE repo compatibility.


9-10: Updated ownership assignments

Appropriate ownership assignments for configuration directories and package resources.

Also applies to: 25-28


31-36: Updated App viewers pod paths

The widget paths have been correctly updated to reflect the new directory structure.


38-82: New AI Agents POD section replaces anvil-team

This section correctly implements the team restructuring from anvil-team to AI Agents POD as mentioned in the PR description. The ownership is properly distributed between FE, BE, and WDS teams with appropriate file patterns.

Key changes:

  • Line 40 reflects the widget relocation from src/modules/ui-builder/ui/wds to src/widgets/wds
  • Line 47 updates ownership for anvil layout system
  • Comprehensive coverage of all related components

85-85: Updated path for feature flags

Path update for feature flags directory with maintained ownership.


131-132: Updated Data Platform paths

Path updates for API Editor and DataSource Editor directories, maintaining ownership by @ayushpahwa.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@KelvinOm KelvinOm force-pushed the fix/codeowners-file branch from ee3e6b8 to d7aac20 Compare February 26, 2025 09:54
@KelvinOm KelvinOm added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Feb 26, 2025
@KelvinOm KelvinOm changed the title Fix/codeowners file fix:codeowners file Feb 26, 2025
@github-actions github-actions bot added the Bug Something isn't working label Feb 26, 2025
jsartisan
jsartisan previously approved these changes Feb 26, 2025
@KelvinOm KelvinOm force-pushed the fix/codeowners-file branch from d4f93eb to 9c5265b Compare February 26, 2025 10:55
app/client/src/utils/hooks/useWidgetSelection.ts @appsmithorg/ai-agents-fe

# # AI Agents BE
app/client/packages/rts/src/chat/** @appsmithorg/ai-agents-be
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KelvinOm KelvinOm merged commit 836b5a5 into release Feb 26, 2025
87 checks passed
@KelvinOm KelvinOm deleted the fix/codeowners-file branch February 26, 2025 12:21
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this pull request Apr 12, 2025
## Description
**Github changes**
- The **anvil-team** was deleted
- **Anvil pod** renamed **AI Agents POD** 
- Created two child teams:
[AI Agents BE](https://github.com/orgs/appsmithorg/teams/ai-agents-be)
[AI Agents FE](https://github.com/orgs/appsmithorg/teams/ai-agents-fe)

**PR changes**
- Moved WDS widgets from `src/modules/ui-builder/ui/wds` to
`src/widgets/wds`
- Updated the paths in CODEOWNERS file
- In CODEOWNERS `@appsmithorg/anvil-team` replaced with
`@appsmithorg/ai-agents-pod`.

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13542264374>
> Commit: 9c5265b
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13542264374&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Wed, 26 Feb 2025 12:06:53 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
- Updated internal code ownership assignments to better reflect team
responsibilities.
- **Refactor**
- Standardized and streamlined internal module imports across UI
components and widgets.
- Removed an outdated component export to optimize the code
organization.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working ok-to-test Required label for CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants