Skip to content

chore: Remove dependancy #39389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vsvamsi1 merged 3 commits into from
Mar 12, 2025
Merged

chore: Remove dependancy #39389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbbc102
Remove dependancy
sagar-qa007 Feb 21, 2025
96d8f10
Log remove
sagar-qa007 Feb 21, 2025
f695cd9
using mutative instead of immer for triggerReducer
vsvamsi1 Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/client/cypress/support/Objects/FeatureFlags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export const getConsolidatedDataApi = (
updatedResponse.data.featureFlags.data = { ...flags };
return res.send(updatedResponse);
} catch (e) {
cy.log(`vamsi error `, e);
cy.log(`Featureflags.ts error `, e);
}
}
});
Expand Down
1 change: 0 additions & 1 deletion app/client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,6 @@
"html-webpack-plugin": "^5.5.0",
"husky": "^8.0.0",
"identity-obj-proxy": "^3.0.0",
"immer": "^9.0.6",
"jest": "^29.6.1",
"jest-canvas-mock": "^2.3.1",
"jest-environment-jsdom": "^29.6.1",
Expand Down
4 changes: 2 additions & 2 deletions app/client/src/reducers/evaluationReducers/triggerReducer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import type {
FormEvalOutput,
FormEvaluationState,
} from "./formEvaluationReducer";
import produce from "immer";
import { create } from "mutative";

// // Type for the object that will store the eval output for the app
export type TriggerValuesEvaluationState = Record<string, FormEvalOutput>;
Expand Down Expand Up @@ -66,7 +66,7 @@ const triggers = createReducer(initialState, {
state: FormEvaluationState,
action: ReduxAction<TriggerActionNextPagePayload>,
) =>
produce(state, (draftState) => {
create(state, (draftState) => {
const { actionId, identifier, value: newValue } = action.payload;

if (!draftState[actionId][identifier].fetchDynamicValues?.data) {
Expand Down
3 changes: 1 addition & 2 deletions app/client/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13512,7 +13512,6 @@ __metadata:
html-webpack-plugin: ^5.5.0
husky: ^8.0.0
identity-obj-proxy: ^3.0.0
immer: ^9.0.6
interweave: ^12.7.2
interweave-autolink: ^4.4.2
jest: ^29.6.1
Expand Down Expand Up @@ -21276,7 +21275,7 @@ __metadata:
languageName: node
linkType: hard

"immer@npm:^9.0.6, immer@npm:^9.0.7":
"immer@npm:^9.0.7":
version: 9.0.21
resolution: "immer@npm:9.0.21"
checksum: 70e3c274165995352f6936695f0ef4723c52c92c92dd0e9afdfe008175af39fa28e76aafb3a2ca9d57d1fb8f796efc4dd1e1cc36f18d33fa5b74f3dfb0375432
Expand Down
Loading