Skip to content

fix: skip snowflake test cases in cypress#39304

Merged
shadabbuchh merged 1 commit intoreleasefrom
fix/skipSnowflakeTests
Feb 17, 2025
Merged

fix: skip snowflake test cases in cypress#39304
shadabbuchh merged 1 commit intoreleasefrom
fix/skipSnowflakeTests

Conversation

@shadabbuchh
Copy link
Contributor

@shadabbuchh shadabbuchh commented Feb 17, 2025

Description

This PR skips snowflake cypress tests.

Fixes #39303

Automation

/ok-to-test tags="@tag.Snowflake"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13363519219
Commit: e3975ef
Cypress dashboard.
Tags: @tag.Snowflake
Spec:


Mon, 17 Feb 2025 05:48:57 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Tests
    • Temporarily disabled the test suite for Snowflake datasource integration due to external service quota issues. Existing test logic remains intact and will resume once the external constraint is resolved.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 17, 2025

Walkthrough

This pull request changes the Cypress test suite for Snowflake Basic Tests by modifying the test declaration from describe to describe.skip. A comment is added to explain that the tests are skipped due to the Snowflake CREDITLIMIT exceeding its quota. No other aspects of the test cases, such as validations, query executions, widget bindings, deletion, or error handling, have been altered.

Changes

File Change Summary
app/.../Snowflake_Basic_Spec.ts Changed test suite declaration from describe to describe.skip with a comment explaining the skip.

Sequence Diagram(s)

sequenceDiagram
    participant Runner as Cypress Test Runner
    participant Suite as Snowflake Basic Test Suite
    Runner->>Suite: Initiate Test Execution
    Note over Suite: Skipped due to CREDITLIMIT issue
    Runner->>Suite: Bypass Execution of Tests
Loading

Possibly related PRs

Suggested labels

skip-changelog, ok-to-test, Google Sheets, Task, Integrations Product, Query & JS Pod

Suggested reviewers

  • ApekshaBhosale
  • sagar-qa007

Poem

In this suite, tests take a rest,
Credit limits put them to test.
A simple skip, no code to run,
Pausing the flow until the issue’s undone.
Celebrate the break with a joyful jest!
😉 Happy coding!


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19acf7c and e3975ef.

📒 Files selected for processing (1)
  • app/client/cypress/e2e/Regression/ServerSide/Datasources/Snowflake_Basic_Spec.ts (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • app/client/cypress/e2e/Regression/ServerSide/Datasources/Snowflake_Basic_Spec.ts
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: perform-test / rts-build / build
  • GitHub Check: perform-test / client-build / client-build
  • GitHub Check: perform-test / server-build / server-unit-tests
  • GitHub Check: client-lint / client-lint
  • GitHub Check: client-unit-tests / client-unit-tests
  • GitHub Check: client-prettier / prettier-check
  • GitHub Check: client-build / client-build

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Task A simple Todo label Feb 17, 2025
@shadabbuchh shadabbuchh added the ok-to-test Required label for CI label Feb 17, 2025
@github-actions github-actions bot added the Bug Something isn't working label Feb 17, 2025
@shadabbuchh shadabbuchh merged commit 8543816 into release Feb 17, 2025
47 checks passed
@shadabbuchh shadabbuchh deleted the fix/skipSnowflakeTests branch February 17, 2025 05:49
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this pull request Apr 12, 2025
## Description
This PR skips snowflake cypress tests.


Fixes appsmithorg#39303

## Automation

/ok-to-test tags="@tag.Snowflake"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13363519219>
> Commit: e3975ef
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13363519219&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Snowflake`
> Spec:
> <hr>Mon, 17 Feb 2025 05:48:57 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Temporarily disabled the test suite for Snowflake datasource
integration due to external service quota issues. Existing test logic
remains intact and will resume once the external constraint is resolved.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working ok-to-test Required label for CI Task A simple Todo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Skip snowflake tests in cypress as snowflake CREDITLIMIT has exceeded its quota

2 participants